host volumes: add configuration to GC on node GC#25903
Merged
Conversation
6 tasks
tgross
force-pushed
the
NMD705-gc-host-volume
branch
from
5c86d79 to
bdcb86e
Compare
tgross
force-pushed
the
NMD705-gc-host-volume
branch
from
bdcb86e to
e19fbfa
Compare
aimeeu
previously approved these changes
May 20, 2025
Contributor
aimeeu
left a comment
aimeeu
left a comment
There was a problem hiding this comment.
Thanks for updating the docs!
6 tasks
When a node is garbage collected, any dynamic host volumes on the node are orphaned in the state store. We generally don't want to automatically collect these volumes and risk data loss, and have provided a CLI flag to `-force` remove them in #25902. But for clusters running on ephemeral cloud instances (ex. AWS EC2 in an autoscaling group), deleting host volumes may add excessive friction. Add a configuration knob to the client configuration to remove host volumes from the state store on node GC. Ref: #25902 Ref: #25762 Ref: https://hashicorp.atlassian.net/browse/NMD-705
tgross
force-pushed
the
NMD705-gc-host-volume
branch
from
e19fbfa to
f4a28f5
Compare
gulducat
approved these changes
May 22, 2025
Member
gulducat
left a comment
gulducat
left a comment
There was a problem hiding this comment.
LGTM!
🫸 🔉 🗑️ (push volume into the garbage)
Comment on lines
+136
to
+145
| raw := req.URL.Query().Get("force") | ||
| var force bool | ||
| if raw != "" { | ||
| var err error | ||
| force, err = strconv.ParseBool(raw) | ||
| if err != nil { | ||
| return nil, CodedError(400, "invalid force value") | ||
| } | ||
| } | ||
| args.Force = force |
Member
There was a problem hiding this comment.
| index, err := v.serializeCall(vol.ID, "delete", func() (uint64, error) { | ||
| if err := v.deleteVolume(vol); err != nil { | ||
| if structs.IsErrUnknownNode(err) { | ||
| if structs.IsErrUnknownNode(err) || structs.IsErrNoNodeConn(err) { |
6 tasks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a node is garbage collected, any dynamic host volumes on the node are orphaned in the state store. We generally don't want to automatically collect these volumes and risk data loss, and have provided a CLI flag to
-forceremove them in #25902. But for clusters running on ephemeral cloud instances (ex. AWS EC2 in an autoscaling group), deleting host volumes may add excessive friction. Add a configuration knob to the client configuration to remove host volumes from the state store on node GC.(This also fixes a bug I discovered in #25902)
Ref: #25902
Ref: #25762
Ref: https://hashicorp.atlassian.net/browse/NMD-705
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.