Skip to content

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented May 23, 2025

Description

This is a redo of #17702

The Datadog Agent docs specifies that you should set cgroupns=host, but I can't do that via nomad.

docker run -d --cgroupns host \
    --pid host \
    --name dd-agent \
    -v /var/run/docker.sock:/var/run/docker.sock:ro \
    -v /proc/:/host/proc/:ro \
    -v /sys/fs/cgroup/:/host/sys/fs/cgroup:ro \
    -e DD_SITE=<DATADOG_SITE> \
    -e DD_API_KEY=<DATADOG_API_KEY> \
    gcr.io/datadoghq/agent:7

#17702 (comment)

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mongey! Thanks for this contribution.

Unfortunately this doesn't seem to compile at the moment, so it doesn't pass tests either. If you can get that patched up we'd be happy to review again.

@tgross tgross moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jun 9, 2025
@Mongey
Copy link
Contributor Author

Mongey commented Jun 9, 2025

@tgross updated, sorry about that 😓

aimeeu
aimeeu previously requested changes Jun 10, 2025
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! I left a suggestion so the docs content matches our docs style guide.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross requested a review from aimeeu June 11, 2025 17:32
@tgross tgross dismissed aimeeu’s stale review June 11, 2025 17:50

Author accepted suggestions.

@tgross tgross merged commit f7096fb into hashicorp:main Jun 11, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Nomad - Community Issues Triage Jun 11, 2025
@tgross tgross added the backport/1.10.x backport to 1.10.x release line label Jun 11, 2025
@tgross
Copy link
Member

tgross commented Jun 11, 2025

@Mongey this will ship in the next regular patch release for Nomad 1.10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.10.x backport to 1.10.x release line theme/docs Documentation issues and enhancements theme/driver/docker type/enhancement
Projects
Development

Successfully merging this pull request may close these issues.

3 participants