-
Notifications
You must be signed in to change notification settings - Fork 2k
docker: add cgroupns task config #25927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mongey! Thanks for this contribution.
Unfortunately this doesn't seem to compile at the moment, so it doesn't pass tests either. If you can get that patched up we'd be happy to review again.
Co-authored-by: Tim Gross <[email protected]>
@tgross updated, sorry about that 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs! I left a suggestion so the docs content matches our docs style guide.
Co-authored-by: Aimee Ukasick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Mongey this will ship in the next regular patch release for Nomad 1.10.x. |
Description
This is a redo of #17702
The Datadog Agent docs specifies that you should set
cgroupns=host
, but I can't do that via nomad.#17702 (comment)
Testing & Reproduction steps
Links
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.