Skip to content

Conversation

allisonlarson
Copy link
Member

@allisonlarson allisonlarson commented Jun 30, 2025

Description

Adds the Kind field to the service block in the jobspec, and allows Consul services to be registered with the Consul Kind type manually. Previously this was only set when using a defined type of Consul Connect gateway, but with the new change, it can be specified on the service itself. If both values (kind and a consul connect gateway) are defined, the service will use the Consul Connect Gateway.

Testing & Reproduction steps

Add kind to jobspec, observe the gateway specified for the service in Consul.

Links

internal Ref https://hashicorp.atlassian.net/browse/NMD-702

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

tgross
tgross previously approved these changes Jun 30, 2025
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Once the test gets fixed)

Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! I left a tiny suggestion so that the text matches our style guide.

@allisonlarson allisonlarson force-pushed the f-add-consul-service-kind-field branch from 9edcf3b to 6c21026 Compare June 30, 2025 20:11
@allisonlarson allisonlarson requested a review from tgross June 30, 2025 20:17
@allisonlarson allisonlarson added the backport/1.10.x backport to 1.10.x release line label Jun 30, 2025
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@allisonlarson allisonlarson requested a review from aimeeu June 30, 2025 21:04
@allisonlarson allisonlarson merged commit 63f0788 into main Jun 30, 2025
45 of 47 checks passed
@allisonlarson allisonlarson deleted the f-add-consul-service-kind-field branch June 30, 2025 21:32
@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.10.x backport to 1.10.x release line theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants