-
Notifications
You must be signed in to change notification settings - Fork 2k
Expose Kind field for Consul Service Registrations #26170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Once the test gets fixed)
1b6afde
to
9edcf3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs! I left a tiny suggestion so that the text matches our style guide.
9edcf3b
to
6c21026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adds the
Kind
field to the service block in the jobspec, and allows Consul services to be registered with the Consul Kind type manually. Previously this was only set when using a defined type of Consul Connect gateway, but with the new change, it can be specified on the service itself. If both values (kind
and a consul connect gateway) are defined, the service will use the Consul Connect Gateway.Testing & Reproduction steps
Add
kind
to jobspec, observe the gateway specified for the service in Consul.Links
internal Ref https://hashicorp.atlassian.net/browse/NMD-702
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.