Add CSI Volume Sentinel Policy scaffolding #26438
Merged
allisonlarson merged 11 commits intomainfrom Aug 7, 2025
Merged
Conversation
tgross
reviewed
Aug 5, 2025
4ecee7d to
54be466
Compare
54be466 to
4ecd0e8
Compare
Contributor
tgross
reviewed
Aug 6, 2025
bf98221 to
73ef794
Compare
aimeeu
reviewed
Aug 7, 2025
Contributor
aimeeu
left a comment
There was a problem hiding this comment.
Thanks for creating/updating the docs. I left some style guide and presentation suggestions. Feel free to contact me if you have questions.
fdbab0e to
0514f34
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds in the scaffolding for enabling Sentinel policies for CSI Volumes in enterprise. The additions are a hook for policy enforcement, and adding an
overridefield to the csi create & register requests and awarningsresponse field. I've also updated the editor in the UI (with tests), and updated the CSI Volume documentation for the new Sentinel policy options. This work is modeled on the Sentinel policy work done for host volumes, so the documentation uses host volumes as the blueprint for the updates.Testing & Reproduction steps
Some tests have been added that should protect against any issues with the added
overrideandwarningfields in the request/responses, but the CSI tests are currently lacking due to the requirement of the running plugin in order to successfully create/register a volume. The tests for the csivolume createandvolume registercommands don't succeed, and instead test that the error returned is expected (missing plugin). I figured that this is somewhat useful for testing that the new inputs/outputs don't blow up, as opposed to having no test at all, but open to any feedback about how to write a useful test.Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.