Skip to content

csi: fix volume registration error#26642

Merged
mismithhisler merged 4 commits intomainfrom
f-fix-volume-register-eof-error
Aug 27, 2025
Merged

csi: fix volume registration error#26642
mismithhisler merged 4 commits intomainfrom
f-fix-volume-register-eof-error

Conversation

@mismithhisler
Copy link
Copy Markdown
Member

Description

Volume registrations were appearing to fail due to returning a nil response object.

Testing & Reproduction steps

Links

Fixes: GH #26581

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@mismithhisler mismithhisler self-assigned this Aug 27, 2025
@mismithhisler mismithhisler requested review from a team as code owners August 27, 2025 14:52
Comment thread command/agent/csi_endpoint.go Outdated
Copy link
Copy Markdown
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Contributor

@allisonlarson allisonlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mismithhisler mismithhisler merged commit 485356c into main Aug 27, 2025
42 checks passed
@mismithhisler mismithhisler deleted the f-fix-volume-register-eof-error branch August 27, 2025 19:00
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSI volume register fails with EOF

4 participants