api: return 403 error when reading variables using invalid token#27269
Merged
mismithhisler merged 4 commits intomainfrom Dec 18, 2025
Merged
api: return 403 error when reading variables using invalid token#27269mismithhisler merged 4 commits intomainfrom
mismithhisler merged 4 commits intomainfrom
Conversation
The Nomad api was previously swallowing 403 errors, which was inconsistent with the rest of the api, and causing unexpected issues with consumers like Consul-Template
mismithhisler
commented
Dec 16, 2025
Co-authored-by: Allison Larson <allison.larson@hashicorp.com>
allisonlarson
approved these changes
Dec 16, 2025
mismithhisler
added
backport/1.11.x
7 tasks
tgross
added a commit
that referenced
this pull request
Jan 22, 2026
In #27269 we improved the Go SDK's treatment of the variables API to correctly return 403. An E2E test of the CLI was expected a "not found" response instead, so this causes the test to fail. But the test also poorly exercised the Task API socket by not ensuring that authentication was working. Update the test to get a variable that exists and that the test has access to. Ref: #27269
7 tasks
tgross
added a commit
that referenced
this pull request
Jan 22, 2026
In #27269 we improved the Go SDK's treatment of the variables API to correctly return 403. An E2E test of the CLI was expected a "not found" response instead, so this causes the test to fail. But the test also poorly exercised the Task API socket by not ensuring that authentication was working. Update the test to get a variable that exists and that the test has access to. Ref: #27269
tgross
added a commit
that referenced
this pull request
Jan 22, 2026
In #27269 we improved the Go SDK's treatment of the variables API to correctly return 403. An E2E test of the CLI was expected a "not found" response instead, so this causes the test to fail. But the test also poorly exercised the Task API socket by not ensuring that authentication was working. Update the test to get a variable that exists and that the test has access to. Ref: #27269
7 tasks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Nomad api was previously swallowing 403 errors, which was inconsistent with the rest of the api, and causing unexpected issues with consumers like Consul-Template
Testing & Reproduction steps
Links
Fixes GH #27117
Fixes GH #24698
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.