Skip to content

fix(ui): add missing namespace when tagging a job version#27282

Merged
pkazmierczak merged 2 commits intohashicorp:mainfrom
sevensolutions:fix/gh-26185
Dec 19, 2025
Merged

fix(ui): add missing namespace when tagging a job version#27282
pkazmierczak merged 2 commits intohashicorp:mainfrom
sevensolutions:fix/gh-26185

Conversation

@sevensolutions
Copy link
Copy Markdown
Contributor

@sevensolutions sevensolutions commented Dec 19, 2025

Description

This PR adds the missing namespace to the server request when tagging a job version from the UI.

Testing & Reproduction steps

See #26185

Links

Fixes #26185

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@sevensolutions sevensolutions marked this pull request as ready for review December 19, 2025 10:07
@sevensolutions sevensolutions requested review from a team as code owners December 19, 2025 10:07
@pkazmierczak pkazmierczak added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line labels Dec 19, 2025
Copy link
Copy Markdown
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested your changes locally and it indeed fixes the issue. Thanks for the contribution, @sevensolutions!

@pkazmierczak pkazmierczak merged commit 840bfc4 into hashicorp:main Dec 19, 2025
23 of 24 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Nomad - Community Issues Triage Dec 19, 2025
@pkazmierczak pkazmierczak removed the backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent label Dec 19, 2025
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/ent/1.10.x+ent backport to 1.10.x+ent release line backport/1.11.x backport to 1.11.x release line

Projects

Development

Successfully merging this pull request may close these issues.

Error tagging job version when trying to tag any job

2 participants