client: Fix task env calculation of alloc addr using static ports.#27305
Merged
client: Fix task env calculation of alloc addr using static ports.#27305
Conversation
The "NOMAD_ALLOC_ADDR_" task env var was not correctly generating the value when the allocation used a static port allocation. The resulting env var would always have an address with its port as 0. The change correctly handles dynamic and static port definitions, so the "NOMAD_ALLOC_ADDR_" is properly formed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "NOMAD_ALLOC_ADDR_" task env var was not correctly generating the value when the allocation used a static port allocation. The resulting env var would always have an address with its port as 0.
The change correctly handles dynamic and static port definitions, so the "NOMAD_ALLOC_ADDR_" is properly formed.
Testing & Reproduction steps
The following job spec can be used on Linux to observe the behaviour:
You can then use the command
nomad alloc exec <alloc_id> envto query the task environment and identify the incorrect task env var.Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.