Skip to content

increase default SecretsCmdTimeout#27779

Merged
tehut merged 1 commit intomainfrom
f-increase-secret-plugin-timeout/nmd-1276
Apr 2, 2026
Merged

increase default SecretsCmdTimeout#27779
tehut merged 1 commit intomainfrom
f-increase-secret-plugin-timeout/nmd-1276

Conversation

@tehut
Copy link
Copy Markdown
Contributor

@tehut tehut commented Apr 1, 2026

#27618 prompted me to share a small design memo around implementing the configuration options proposed in our internal CPI RFC (NMD-02). The decision to increase the default timeout instead of implementing configuration was an option that grew out of our discussion of that memo.

This PR just increases the default time from 10s -> 60s.

refs:
jira: https://hashicorp.atlassian.net/browse/NMD-1276
gh issue: #27618
docs pr: hashicorp/web-unified-docs#2119

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@tehut tehut marked this pull request as ready for review April 1, 2026 18:17
@tehut tehut requested review from a team as code owners April 1, 2026 18:17
@tehut tehut added backport/1.11.x backport to 1.11.x release line backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/2.0.x backport to 2.0.x release line backport/ent/2.0.x+ent backport to 2.0.x+ent release line labels Apr 1, 2026
Comment thread .changelog/27779.txt Outdated
@@ -0,0 +1,3 @@
```release-note:improvement
secrets: increase timeout
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
secrets: increase timeout
secrets: increase plugin execution timeout from 10 to 60 seconds

we have some inconsistency about present-vs-past tense (like "increased") or Capitalization in these things, but a bit more info is helpful for folks who read this later without context

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, I think I was doing some weird security by obscurity thing. Not really reasonable on an open source project 🤦

@tehut tehut force-pushed the f-increase-secret-plugin-timeout/nmd-1276 branch from 9b7e763 to 9831e22 Compare April 1, 2026 22:00
@tehut tehut requested a review from gulducat April 1, 2026 22:01
@tehut tehut force-pushed the f-increase-secret-plugin-timeout/nmd-1276 branch from 9831e22 to 288e929 Compare April 2, 2026 18:17
Copy link
Copy Markdown
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for all the option-weighing and consensus-building that went into this one-line change 👏

@tehut tehut merged commit d9d98c0 into main Apr 2, 2026
37 checks passed
@tehut tehut deleted the f-increase-secret-plugin-timeout/nmd-1276 branch April 2, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/ent/2.0.x+ent backport to 2.0.x+ent release line backport/1.11.x backport to 1.11.x release line backport/2.0.x backport to 2.0.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants