Skip to content

this hack can be reverted now that we've fixed the underlying bug in … #8377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

SwampDragons
Copy link
Contributor

#8369 fixed the underlying bug that was causing this eof error; just tested against Azure and I can no longer reproduce the crash that caused the need for this sleep.

@SwampDragons SwampDragons requested a review from a team as a code owner November 15, 2019 23:01
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azr azr merged commit ad34a45 into master Nov 18, 2019
@azr azr deleted the revert_windows_restart_hack branch November 18, 2019 09:48
@ghost
Copy link

ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants