Skip to content

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jun 21, 2024

Closes: #801

This PR introduces Int32 type support to terraform-plugin-framework with the addition of:

  • Int32 type and value implementations: types.Int32Type and types.Int32
  • Custom type interfaces:basetypes.Int32Typable, basetypes.Int32Valuable and basetypes.Int32ValuableWithSemanticEquals
  • Attribute support: schema.Int32Attribute for resource, data source, and provider schemas
  • Function support: function.Int32Parameter and function.Int32Return
  • Int32 plan modifier interfaces and implementations (requires replace, use state if unknown, etc.)
  • Int32 default interfaces and static implementation
  • Int32 validation interface: validator.Int32

@SBGoods SBGoods requested a review from a team as a code owner June 21, 2024 17:13
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some suggestions in the PR

I see references to float32 attributes that don't exist but it seems likely they'll go in the same release of terraform-plugin-framework v1.10.0

@austinvalle austinvalle added this to the v1.10.0 milestone Jun 24, 2024
@austinvalle austinvalle added the enhancement New feature or request label Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Int32 type

2 participants