Skip to content

[BREAKING] 💥 remove compute environments from job queue #40751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 29, 2025
Merged

[BREAKING] 💥 remove compute environments from job queue #40751

merged 14 commits into from
Apr 29, 2025

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 2, 2025 •
edited by YakDriver
Loading

Description

  • Remove deprecated parameter compute_environments
  • Replace SDKMigration test with compute environments removal test
  • Change read function to use autoflex

Relations

Closes #39568
Closes #34794
Relates #34750
Relates #38050 (missing StateUpgrader, failed to rename all the places compute_environment_name (vs. name) was used)

References

Output from Acceptance Testing

Note: ACCTEST_PARALLELISM is used in this test due to the creation of VPC limits.

% TF_ACC=1 make testacc TESTS=TestAccBatchJobQueue_ ACCTEST_PARALLELISM=2 PKG=batch                                                                                               
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/batch/... -v -count 1 -parallel 2 -run='TestAccBatchJobQueue_'  -timeout 360m
2025/01/02 14:17:22 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobQueue_migrateFromComputeEnvironments
=== PAUSE TestAccBatchJobQueue_migrateFromComputeEnvironments
=== RUN   TestAccBatchJobQueue_tags
=== PAUSE TestAccBatchJobQueue_tags
=== RUN   TestAccBatchJobQueue_tags_null
=== PAUSE TestAccBatchJobQueue_tags_null
=== RUN   TestAccBatchJobQueue_tags_EmptyMap
=== PAUSE TestAccBatchJobQueue_tags_EmptyMap
=== RUN   TestAccBatchJobQueue_tags_AddOnUpdate
=== PAUSE TestAccBatchJobQueue_tags_AddOnUpdate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== RUN   TestAccBatchJobQueue_disappears
=== PAUSE TestAccBatchJobQueue_disappears
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== RUN   TestAccBatchJobQueue_priority
=== PAUSE TestAccBatchJobQueue_priority
=== RUN   TestAccBatchJobQueue_schedulingPolicy
=== PAUSE TestAccBatchJobQueue_schedulingPolicy
=== RUN   TestAccBatchJobQueue_state
=== PAUSE TestAccBatchJobQueue_state
=== RUN   TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== PAUSE TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== CONT  TestAccBatchJobQueue_migrateFromComputeEnvironments
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag (134.69s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobQueue_migrateFromComputeEnvironments (162.15s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_providerOnly (186.92s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag (164.53s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag (132.85s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag (131.89s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly (146.94s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly (146.96s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_overlapping (166.82s)
=== CONT  TestAccBatchJobQueue_tags_AddOnUpdate
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping (167.05s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace (134.74s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_AddOnUpdate (140.82s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnCreate
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnCreate (142.85s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_multiple
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add (145.84s)
=== CONT  TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
--- PASS: TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple (167.44s)
=== CONT  TestAccBatchJobQueue_state
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_multiple (170.09s)
=== CONT  TestAccBatchJobQueue_schedulingPolicy
--- PASS: TestAccBatchJobQueue_state (168.71s)
=== CONT  TestAccBatchJobQueue_priority
--- PASS: TestAccBatchJobQueue_schedulingPolicy (175.17s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate (127.99s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
--- PASS: TestAccBatchJobQueue_priority (167.75s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple (168.41s)
=== CONT  TestAccBatchJobQueue_disappears
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag (157.51s)
=== CONT  TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobQueue_disappears (126.26s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobQueue_basic (132.15s)
=== CONT  TestAccBatchJobQueue_tags
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag (149.95s)
=== CONT  TestAccBatchJobQueue_tags_EmptyMap
--- PASS: TestAccBatchJobQueue_tags (166.42s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_EmptyMap (131.84s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add (164.80s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnCreate
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace (145.32s)
=== CONT  TestAccBatchJobQueue_tags_null
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnCreate (136.28s)
--- PASS: TestAccBatchJobQueue_tags_null (131.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	2382.990s
% TF_ACC=1 make testacc TESTS=TestAccEventsTarget_batch PKG=events                                                                                                                
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsTarget_batch'  -timeout 360m
2025/01/02 15:00:34 Initializing Terraform AWS Provider...
=== RUN   TestAccEventsTarget_batch
=== PAUSE TestAccEventsTarget_batch
=== CONT  TestAccEventsTarget_batch
--- PASS: TestAccEventsTarget_batch (136.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	140.333s
% TF_ACC=1 make testacc TESTS=TestAccPipesPipe_sqsSourceBatchJobTarget PKG=pipes                                                                                                  <aws:provider> <region:us-east-2>
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_sqsSourceBatchJobTarget'  -timeout 360m
2025/01/02 15:07:55 Initializing Terraform AWS Provider...
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (159.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	163.286s

@danquack danquack requested a review from a team as a code owner January 2, 2025 20:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/batch Issues and PRs that pertain to the batch service. service/events Issues and PRs that pertain to the events service. service/pipes Issues and PRs that pertain to the pipes service. needs-triage Waiting for first response or review from a maintainer. labels Jan 2, 2025
@danquack danquack force-pushed the 39568/migrate-compute-environment branch from 4e08da4 to bf8c04d Compare January 2, 2025 21:25
@drewmullen drewmullen added this to the v6.0.0 milestone Jan 6, 2025
@drewmullen drewmullen added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 6, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 6, 2025
@breathingdust breathingdust mentioned this pull request Mar 25, 2025
Closed
@YakDriver YakDriver self-assigned this Apr 28, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 28, 2025
@YakDriver YakDriver changed the base branch from main to release/6.0.0-beta April 28, 2025 18:04
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Apr 28, 2025
@github-actions GitHub Actions
Copy link

⚠️ We've detected the following potential issues with your pull request

Unneccessary Changelog Changes

The CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Changelog Process section of the contributing guide for additional information.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging it.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. provider Pertains to the provider itself, rather than any interaction with AWS. tags Pertains to resource tagging. labels Apr 28, 2025
YakDriver
YakDriver previously approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

% make t T=TestAccBatchComputeEnvironment_ K=batch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchComputeEnvironment_'  -timeout 360m -vet=off
2025/04/28 16:25:03 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchComputeEnvironment_tags
=== PAUSE TestAccBatchComputeEnvironment_tags
=== RUN   TestAccBatchComputeEnvironment_tags_null
=== PAUSE TestAccBatchComputeEnvironment_tags_null
=== RUN   TestAccBatchComputeEnvironment_tags_EmptyMap
=== PAUSE TestAccBatchComputeEnvironment_tags_EmptyMap
=== RUN   TestAccBatchComputeEnvironment_tags_AddOnUpdate
=== PAUSE TestAccBatchComputeEnvironment_tags_AddOnUpdate
=== RUN   TestAccBatchComputeEnvironment_tags_EmptyTag_OnCreate
=== PAUSE TestAccBatchComputeEnvironment_tags_EmptyTag_OnCreate
=== RUN   TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_providerOnly
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_providerOnly
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_overlapping
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_overlapping
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccBatchComputeEnvironment_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBatchComputeEnvironment_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccBatchComputeEnvironment_tags_ComputedTag_OnCreate
=== PAUSE TestAccBatchComputeEnvironment_tags_ComputedTag_OnCreate
=== RUN   TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchComputeEnvironment_basic
=== PAUSE TestAccBatchComputeEnvironment_basic
=== RUN   TestAccBatchComputeEnvironment_disappears
=== PAUSE TestAccBatchComputeEnvironment_disappears
=== RUN   TestAccBatchComputeEnvironment_nameGenerated
=== PAUSE TestAccBatchComputeEnvironment_nameGenerated
=== RUN   TestAccBatchComputeEnvironment_namePrefix
=== PAUSE TestAccBatchComputeEnvironment_namePrefix
=== RUN   TestAccBatchComputeEnvironment_upgradeV0ToV1
=== PAUSE TestAccBatchComputeEnvironment_upgradeV0ToV1
=== RUN   TestAccBatchComputeEnvironment_eksConfiguration
=== PAUSE TestAccBatchComputeEnvironment_eksConfiguration
=== RUN   TestAccBatchComputeEnvironment_createEC2
=== PAUSE TestAccBatchComputeEnvironment_createEC2
=== RUN   TestAccBatchComputeEnvironment_updatePolicyCreate
=== PAUSE TestAccBatchComputeEnvironment_updatePolicyCreate
=== RUN   TestAccBatchComputeEnvironment_updatePolicyUpdate
=== PAUSE TestAccBatchComputeEnvironment_updatePolicyUpdate
=== RUN   TestAccBatchComputeEnvironment_CreateEC2DesiredVCPUsEC2KeyPairImageID_computeResourcesTags
=== PAUSE TestAccBatchComputeEnvironment_CreateEC2DesiredVCPUsEC2KeyPairImageID_computeResourcesTags
=== RUN   TestAccBatchComputeEnvironment_createSpot
=== PAUSE TestAccBatchComputeEnvironment_createSpot
=== RUN   TestAccBatchComputeEnvironment_CreateSpotAllocationStrategy_bidPercentage
=== PAUSE TestAccBatchComputeEnvironment_CreateSpotAllocationStrategy_bidPercentage
=== RUN   TestAccBatchComputeEnvironment_createFargate
=== PAUSE TestAccBatchComputeEnvironment_createFargate
=== RUN   TestAccBatchComputeEnvironment_createFargateSpot
=== PAUSE TestAccBatchComputeEnvironment_createFargateSpot
=== RUN   TestAccBatchComputeEnvironment_updateState
=== PAUSE TestAccBatchComputeEnvironment_updateState
=== RUN   TestAccBatchComputeEnvironment_updateServiceRole
=== PAUSE TestAccBatchComputeEnvironment_updateServiceRole
=== RUN   TestAccBatchComputeEnvironment_defaultServiceRole
=== PAUSE TestAccBatchComputeEnvironment_defaultServiceRole
=== RUN   TestAccBatchComputeEnvironment_ComputeResources_minVCPUs
=== PAUSE TestAccBatchComputeEnvironment_ComputeResources_minVCPUs
=== RUN   TestAccBatchComputeEnvironment_ComputeResources_maxVCPUs
=== PAUSE TestAccBatchComputeEnvironment_ComputeResources_maxVCPUs
=== RUN   TestAccBatchComputeEnvironment_ec2Configuration
=== PAUSE TestAccBatchComputeEnvironment_ec2Configuration
=== RUN   TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
=== PAUSE TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
=== RUN   TestAccBatchComputeEnvironment_launchTemplate
=== PAUSE TestAccBatchComputeEnvironment_launchTemplate
=== RUN   TestAccBatchComputeEnvironment_updateLaunchTemplate
=== PAUSE TestAccBatchComputeEnvironment_updateLaunchTemplate
=== RUN   TestAccBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_fargate
=== PAUSE TestAccBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_fargate
=== RUN   TestAccBatchComputeEnvironment_createUnmanagedWithComputeResources
=== PAUSE TestAccBatchComputeEnvironment_createUnmanagedWithComputeResources
=== RUN   TestAccBatchComputeEnvironment_updateEC2
=== PAUSE TestAccBatchComputeEnvironment_updateEC2
=== RUN   TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
=== PAUSE TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
=== CONT  TestAccBatchComputeEnvironment_tags
=== CONT  TestAccBatchComputeEnvironment_namePrefix
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccBatchComputeEnvironment_nameGenerated
=== CONT  TestAccBatchComputeEnvironment_disappears
=== CONT  TestAccBatchComputeEnvironment_basic
=== CONT  TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Replace
=== CONT  TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Add
=== CONT  TestAccBatchComputeEnvironment_tags_ComputedTag_OnCreate
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccBatchComputeEnvironment_updateServiceRole
=== CONT  TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
=== CONT  TestAccBatchComputeEnvironment_updateEC2
=== CONT  TestAccBatchComputeEnvironment_createUnmanagedWithComputeResources
=== CONT  TestAccBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_fargate
=== CONT  TestAccBatchComputeEnvironment_updateLaunchTemplate
=== CONT  TestAccBatchComputeEnvironment_launchTemplate
=== CONT  TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
--- PASS: TestAccBatchComputeEnvironment_createUnmanagedWithComputeResources (3.78s)
=== CONT  TestAccBatchComputeEnvironment_ec2Configuration
--- PASS: TestAccBatchComputeEnvironment_nameGenerated (35.89s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchComputeEnvironment_namePrefix (48.53s)
=== CONT  TestAccBatchComputeEnvironment_ComputeResources_maxVCPUs
--- PASS: TestAccBatchComputeEnvironment_launchTemplate (52.08s)
=== CONT  TestAccBatchComputeEnvironment_ComputeResources_minVCPUs
--- PASS: TestAccBatchComputeEnvironment_ec2Configuration (53.42s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchComputeEnvironment_createEC2WithoutComputeResources (59.49s)
=== CONT  TestAccBatchComputeEnvironment_defaultServiceRole
--- PASS: TestAccBatchComputeEnvironment_disappears (62.99s)
=== CONT  TestAccBatchComputeEnvironment_tags_AddOnUpdate
--- PASS: TestAccBatchComputeEnvironment_tags_ComputedTag_OnCreate (63.24s)
=== CONT  TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Replace (71.63s)
=== CONT  TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchComputeEnvironment_tags_ComputedTag_OnUpdate_Add (71.76s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_emptyProviderOnlyTag (72.28s)
=== CONT  TestAccBatchComputeEnvironment_tags_EmptyTag_OnCreate
--- PASS: TestAccBatchComputeEnvironment_updateServiceRole (77.22s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_nullOverlappingResourceTag (45.38s)
=== CONT  TestAccBatchComputeEnvironment_CreateEC2DesiredVCPUsEC2KeyPairImageID_computeResourcesTags
--- PASS: TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_ResourceTag (80.69s)
=== CONT  TestAccBatchComputeEnvironment_updateState
--- PASS: TestAccBatchComputeEnvironment_UpdateSecurityGroupsAndSubnets_fargate (82.30s)
=== CONT  TestAccBatchComputeEnvironment_createFargateSpot
--- PASS: TestAccBatchComputeEnvironment_basic (84.05s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_overlapping
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_emptyResourceTag (85.63s)
=== CONT  TestAccBatchComputeEnvironment_createFargate
--- PASS: TestAccBatchComputeEnvironment_updateLaunchTemplate (85.99s)
=== CONT  TestAccBatchComputeEnvironment_CreateSpotAllocationStrategy_bidPercentage
--- PASS: TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup (92.77s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchComputeEnvironment_defaultServiceRole (39.22s)
=== CONT  TestAccBatchComputeEnvironment_createSpot
--- PASS: TestAccBatchComputeEnvironment_tags_IgnoreTags_Overlap_DefaultTag (99.07s)
=== CONT  TestAccBatchComputeEnvironment_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchComputeEnvironment_tags_EmptyTag_OnCreate (63.65s)
=== CONT  TestAccBatchComputeEnvironment_tags_null
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_nullNonOverlappingResourceTag (43.96s)
=== CONT  TestAccBatchComputeEnvironment_tags_EmptyMap
=== CONT  TestAccBatchComputeEnvironment_createEC2
--- PASS: TestAccBatchComputeEnvironment_tags_AddOnUpdate (46.95s)
--- PASS: TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Replace (53.42s)
=== CONT  TestAccBatchComputeEnvironment_updatePolicyUpdate
--- PASS: TestAccBatchComputeEnvironment_ComputeResources_maxVCPUs (69.38s)
=== CONT  TestAccBatchComputeEnvironment_updatePolicyCreate
--- PASS: TestAccBatchComputeEnvironment_tags (125.38s)
=== CONT  TestAccBatchComputeEnvironment_eksConfiguration
--- PASS: TestAccBatchComputeEnvironment_createFargate (42.16s)
=== CONT  TestAccBatchComputeEnvironment_upgradeV0ToV1
--- PASS: TestAccBatchComputeEnvironment_CreateSpotAllocationStrategy_bidPercentage (44.17s)
--- PASS: TestAccBatchComputeEnvironment_updateEC2 (138.23s)
--- PASS: TestAccBatchComputeEnvironment_updateState (57.69s)
--- PASS: TestAccBatchComputeEnvironment_createFargateSpot (56.20s)
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_updateToProviderOnly (61.57s)
--- PASS: TestAccBatchComputeEnvironment_tags_EmptyTag_OnUpdate_Add (68.24s)
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_updateToResourceOnly (72.01s)
--- PASS: TestAccBatchComputeEnvironment_tags_EmptyMap (43.06s)
--- PASS: TestAccBatchComputeEnvironment_tags_null (49.42s)
--- PASS: TestAccBatchComputeEnvironment_createEC2 (48.69s)
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_overlapping (81.73s)
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_nonOverlapping (74.19s)
--- PASS: TestAccBatchComputeEnvironment_CreateEC2DesiredVCPUsEC2KeyPairImageID_computeResourcesTags (95.91s)
--- PASS: TestAccBatchComputeEnvironment_updatePolicyUpdate (58.95s)
--- PASS: TestAccBatchComputeEnvironment_updatePolicyCreate (66.59s)
--- PASS: TestAccBatchComputeEnvironment_upgradeV0ToV1 (66.04s)
--- PASS: TestAccBatchComputeEnvironment_tags_DefaultTags_providerOnly (100.71s)
--- PASS: TestAccBatchComputeEnvironment_ComputeResources_minVCPUs (191.61s)
--- PASS: TestAccBatchComputeEnvironment_createSpot (462.35s)
--- PASS: TestAccBatchComputeEnvironment_eksConfiguration (610.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	740.335s
% make t T=TestAccBatchJobQueue_ K=batch P=3                     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.2 test ./internal/service/batch/... -v -count 1 -parallel 3 -run='TestAccBatchJobQueue_'  -timeout 360m -vet=off
2025/04/28 16:27:20 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobQueue_tags
=== PAUSE TestAccBatchJobQueue_tags
=== RUN   TestAccBatchJobQueue_tags_null
=== PAUSE TestAccBatchJobQueue_tags_null
=== RUN   TestAccBatchJobQueue_tags_EmptyMap
=== PAUSE TestAccBatchJobQueue_tags_EmptyMap
=== RUN   TestAccBatchJobQueue_tags_AddOnUpdate
=== PAUSE TestAccBatchJobQueue_tags_AddOnUpdate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_providerOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_overlapping
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBatchJobQueue_basic
=== PAUSE TestAccBatchJobQueue_basic
=== RUN   TestAccBatchJobQueue_disappears
=== PAUSE TestAccBatchJobQueue_disappears
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== PAUSE TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
=== RUN   TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== PAUSE TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
=== RUN   TestAccBatchJobQueue_priority
=== PAUSE TestAccBatchJobQueue_priority
=== RUN   TestAccBatchJobQueue_schedulingPolicy
=== PAUSE TestAccBatchJobQueue_schedulingPolicy
=== RUN   TestAccBatchJobQueue_state
=== PAUSE TestAccBatchJobQueue_state
=== RUN   TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== PAUSE TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
=== RUN   TestAccBatchJobQueue_upgradeComputeEnvironments
=== PAUSE TestAccBatchJobQueue_upgradeComputeEnvironments
=== CONT  TestAccBatchJobQueue_tags
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnCreate
=== CONT  TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnCreate (161.48s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping
--- PASS: TestAccBatchJobQueue_tags (192.88s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_ComputeEnvironmentOrder_multiple (230.53s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullNonOverlappingResourceTag (147.00s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nonOverlapping (181.59s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_nullOverlappingResourceTag (176.87s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyResourceTag (163.52s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_emptyProviderOnlyTag (198.10s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_overlapping
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToResourceOnly (187.50s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnCreate
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_updateToProviderOnly (182.27s)
=== CONT  TestAccBatchJobQueue_tags_DefaultTags_providerOnly
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_overlapping (182.33s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnCreate (195.05s)
=== CONT  TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Add (168.11s)
=== CONT  TestAccBatchJobQueue_state
--- PASS: TestAccBatchJobQueue_tags_EmptyTag_OnUpdate_Replace (166.26s)
=== CONT  TestAccBatchJobQueue_upgradeComputeEnvironments
--- PASS: TestAccBatchJobQueue_tags_DefaultTags_providerOnly (220.89s)
=== CONT  TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple
--- PASS: TestAccBatchJobQueue_state (191.73s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBatchJobQueue_upgradeComputeEnvironments (186.30s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_multiple
--- PASS: TestAccBatchJobQueue_jobStateTimeLimitActionsMultiple (191.26s)
=== CONT  TestAccBatchJobQueue_disappears
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_ResourceTag (154.71s)
=== CONT  TestAccBatchJobQueue_basic
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_multiple (188.29s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccBatchJobQueue_disappears (169.40s)
=== CONT  TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccBatchJobQueue_basic (155.70s)
=== CONT  TestAccBatchJobQueue_tags_EmptyMap
--- PASS: TestAccBatchJobQueue_tags_IgnoreTags_Overlap_DefaultTag (169.54s)
=== CONT  TestAccBatchJobQueue_tags_AddOnUpdate
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Replace (179.39s)
=== CONT  TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccBatchJobQueue_tags_EmptyMap (132.94s)
--- PASS: TestAccBatchJobQueue_tags_null (146.66s)
=== CONT  TestAccBatchJobQueue_schedulingPolicy
--- PASS: TestAccBatchJobQueue_tags_ComputedTag_OnUpdate_Add (196.90s)
=== CONT  TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate
--- PASS: TestAccBatchJobQueue_priority (193.08s)
--- PASS: TestAccBatchJobQueue_ComputeEnvironments_externalOrderUpdate (152.67s)
--- PASS: TestAccBatchJobQueue_schedulingPolicy (230.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	1834.281s

YakDriver
YakDriver previously approved these changes Apr 28, 2025
View reviewed changes
YakDriver
YakDriver previously approved these changes Apr 28, 2025
View reviewed changes
jar-b
jar-b reviewed Apr 29, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple testing suggestions, otherwise looks good!

YakDriver
YakDriver approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated tests:

% make t T=TestAccBatchComputeEnvironment_upgradeV0ToV1 K=batch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchComputeEnvironment_upgradeV0ToV1'  -timeout 360m -vet=off
2025/04/29 13:08:17 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchComputeEnvironment_upgradeV0ToV1
=== PAUSE TestAccBatchComputeEnvironment_upgradeV0ToV1
=== CONT  TestAccBatchComputeEnvironment_upgradeV0ToV1
--- PASS: TestAccBatchComputeEnvironment_upgradeV0ToV1 (55.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	59.671s
% make t T=TestAccBatchJobQueue_upgradeComputeEnvironments K=batch
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.2 test ./internal/service/batch/... -v -count 1 -parallel 20 -run='TestAccBatchJobQueue_upgradeComputeEnvironments'  -timeout 360m -vet=off
2025/04/29 13:08:00 Initializing Terraform AWS Provider...
=== RUN   TestAccBatchJobQueue_upgradeComputeEnvironments
=== PAUSE TestAccBatchJobQueue_upgradeComputeEnvironments
=== CONT  TestAccBatchJobQueue_upgradeComputeEnvironments
--- PASS: TestAccBatchJobQueue_upgradeComputeEnvironments (189.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	193.382s

jar-b
jar-b approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit dd34c67 into hashicorp:release/6.0.0-beta Apr 29, 2025
46 checks passed
@github-actions GitHub Actions
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot modified the milestones: v6.0.0, v6.0.0-beta1 Apr 29, 2025
This was referenced Apr 29, 2025
Closed
Closed
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

This functionality has been released in v6.0.0-beta1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. provider Pertains to the provider itself, rather than any interaction with AWS. service/batch Issues and PRs that pertain to the batch service. service/ecs Issues and PRs that pertain to the ecs service. service/events Issues and PRs that pertain to the events service. service/pipes Issues and PRs that pertain to the pipes service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.0.0-beta1
5 participants
@danquack @jar-b @YakDriver @ewbankkit @drewmullen