-
Notifications
You must be signed in to change notification settings - Fork 408
fix(kubeconfig): Enforces kubernetes context with helm release namespace #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubeconfig): Enforces kubernetes context with helm release namespace #1583
Conversation
6274809 to
39b117e
Compare
|
Hey @flavioab 👋 thanks for the fix—it makes sense to explicitly enforce the namespace override here, especially for charts with dependencies. To help us ensure we don’t regress this behavior in the future, would you mind adding an acceptance test that reproduces the issue and validates that dependency resources get installed in the correct namespace? Let me know if you need help mocking up a test case—happy to help! |
|
Hi @JaylonmcShan03 , finally an update on this 🙌 . I will try to increment the acceptance tests this weekend, thought about adding it before, but badly knew if this PR would be considered at some point. |
|
@JaylonmcShan03 , acceptance tests are in place. Please feel free to make any changes on this if necessary. This test will iterate over all resources from the release and assert if the namespace is correct. |
Checks if all resources are deployed to the correct namespace. Only Resources bound to specific namespaces are checked, the rest is ignored.
e264ea2 to
6ea9158
Compare
|
@JaylonmcShan03, are there any updates? Please let me know if you still need assistance with this PR. |
JaylonmcShan03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @flavioab Just reviewed and the changes introduced looks spot on! Can you rebase this pr onto the current main?
|
Any updates? This is affecting us quite badly and I can't find a workaround! Example: where var.flux_namespace = flux-system. The helm is created on flux-system but the rests of the objects on default namespace! |
|
Hi @cradules , been checking on this once per week since Feb..... been a really slow process overall |
|
Hi @flavioab Sorry for the late response! Can you please add a changelog entry! Once that is tackled, I can approve :) |
No longer have access to the account
Description
Overriding Kubernetes context default namespace with helm release namespace.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
#1582 #1591
Community Note