Skip to content

Conversation

@flavioab
Copy link
Contributor

@flavioab flavioab commented Feb 6, 2025

Description

Overriding Kubernetes context default namespace with helm release namespace.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Fix for dependency charts installed in non-default namespaces

References

#1582 #1591

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@flavioab flavioab requested a review from a team as a code owner February 6, 2025 18:52
@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@JaylonmcShan03
Copy link

Hey @flavioab 👋 thanks for the fix—it makes sense to explicitly enforce the namespace override here, especially for charts with dependencies.

To help us ensure we don’t regress this behavior in the future, would you mind adding an acceptance test that reproduces the issue and validates that dependency resources get installed in the correct namespace?

Let me know if you need help mocking up a test case—happy to help!

@flavioab
Copy link
Contributor Author

flavioab commented Apr 11, 2025

Hi @JaylonmcShan03 , finally an update on this 🙌 . I will try to increment the acceptance tests this weekend, thought about adding it before, but badly knew if this PR would be considered at some point.

@github-actions github-actions bot added size/S and removed size/XS labels Apr 12, 2025
@flavioab
Copy link
Contributor Author

@JaylonmcShan03 , acceptance tests are in place. Please feel free to make any changes on this if necessary. This test will iterate over all resources from the release and assert if the namespace is correct.

Checks if all resources are deployed to the correct namespace.
Only Resources bound to specific namespaces are checked, the
rest is ignored.
@flavioab flavioab force-pushed the 1582/fix-namespace-behavior branch from e264ea2 to 6ea9158 Compare April 12, 2025 18:25
@flavioab
Copy link
Contributor Author

@JaylonmcShan03, are there any updates? Please let me know if you still need assistance with this PR.

Copy link

@JaylonmcShan03 JaylonmcShan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @flavioab Just reviewed and the changes introduced looks spot on! Can you rebase this pr onto the current main?

@aldegoeij
Copy link

Hi, @flavioab Just reviewed and the changes introduced looks spot on! Can you rebase this pr onto the current main?

@flavioab 💘

@flavioab flavioab requested a review from JaylonmcShan03 May 30, 2025 22:08
@cradules
Copy link

cradules commented Jun 6, 2025

Any updates? This is affecting us quite badly and I can't find a workaround!

Example:
resource "helm_release" "flux" {
name = "flux"
namespace = var.flux_namespace
repository = "https://fluxcd-community.github.io/helm-charts"
chart = "flux2"
version = var.flux_version
create_namespace = true
set = [
{
name = "installCRDs"
value = "true"
}
]
}

where var.flux_namespace = flux-system.

The helm is created on flux-system but the rests of the objects on default namespace!

@flavioab
Copy link
Contributor Author

flavioab commented Jun 6, 2025

Hi @cradules , been checking on this once per week since Feb..... been a really slow process overall

@vravind1 vravind1 added this to the Release v3.0.0 milestone Jun 11, 2025
@jaylonmcshan19-x
Copy link
Collaborator

Hi @flavioab Sorry for the late response! Can you please add a changelog entry! Once that is tackled, I can approve :)

@jaylonmcshan19-x jaylonmcshan19-x requested review from jaylonmcshan19-x and removed request for JaylonmcShan03 June 17, 2025 15:15
@jaylonmcshan19-x jaylonmcshan19-x dismissed JaylonmcShan03’s stale review June 17, 2025 15:17

No longer have access to the account

@jrhouston jrhouston merged commit 01475f8 into hashicorp:main Jun 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants