earlydecoder: Avoid producing diagnostics for unknown blocks (#238)

Author: radeksimko

earlydecoder/backend.go

@@ -32,18 +32,18 @@ func decodeBackendsBlock(block *hcl.Block) (backend.BackendData, hcl.Diagnostics
 }
 
 func decodeCloudBlock(block *hcl.Block) (*backend.Cloud, hcl.Diagnostics) {
-	attrs, diags := block.Body.JustAttributes()
+	attrs, _ := block.Body.JustAttributes()
+	// Ignore diagnostics which may complain about unknown blocks
 
 	// https://developer.hashicorp.com/terraform/language/settings/terraform-cloud#usage-example
 	// Required for Terraform Enterprise
 	// Defaults to app.terraform.io for Terraform Cloud
 	if attr, ok := attrs["hostname"]; ok {
 		val, vDiags := attr.Expr.Value(nil)
-		diags = append(diags, vDiags...)
 		if val.IsWhollyKnown() && val.Type() == cty.String {
 			return &backend.Cloud{
 				Hostname: val.AsString(),
-			}, diags
+			}, vDiags
 		}
 	}
 

earlydecoder/decoder_test.go

@@ -1046,6 +1046,32 @@ terraform {
 			},
 			nil,
 		},
+		{
+			"additional block",
+			`
+terraform {
+	cloud {
+		hostname = "foo.com"
+		workspaces {
+			tags = ["app"]
+		}
+	}
+}`,
+			&module.Meta{
+				Path:    path,
+				Backend: nil,
+				Cloud: &backend.Cloud{
+					Hostname: "foo.com",
+				},
+				ProviderReferences:   map[module.ProviderRef]tfaddr.Provider{},
+				ProviderRequirements: map[tfaddr.Provider]version.Constraints{},
+				Variables:            map[string]module.Variable{},
+				Outputs:              map[string]module.Output{},
+				Filenames:            []string{"test.tf"},
+				ModuleCalls:          map[string]module.DeclaredModuleCall{},
+			},
+			nil,
+		},
 	}
 
 	runTestCases(testCases, t, path)