stacks: follow component progress cycle for empty destroys

We expect a component instances to report its plan/apply starting and ending as
well as reporting the progress / result. This should also be the case for no-ops
like an empty component instance.

Author: DanielMSchmidt

internal/stacks/stackruntime/apply_destroy_test.go

@@ -1718,6 +1718,18 @@ func TestApplyDestroy(t *testing.T) {
 								InstanceAddrs: []stackaddrs.AbsComponentInstance{mustAbsComponentInstance("component.self")},
 							},
 						},
+						PendingComponentInstancePlan: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						BeginComponentInstancePlan: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						EndComponentInstancePlan: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						ReportComponentInstancePlanned: []*hooks.ComponentInstanceChange{{
+							Addr: mustAbsComponentInstance("component.self"),
+						}},
 					},
 					wantAppliedHooks: &ExpectedHooks{
 						ComponentExpanded: []*hooks.ComponentInstances{
@@ -1726,6 +1738,18 @@ func TestApplyDestroy(t *testing.T) {
 								InstanceAddrs: []stackaddrs.AbsComponentInstance{mustAbsComponentInstance("component.self")},
 							},
 						},
+						PendingComponentInstanceApply: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						BeginComponentInstanceApply: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						EndComponentInstanceApply: collections.NewSet[stackaddrs.AbsComponentInstance](
+							mustAbsComponentInstance("component.self"),
+						),
+						ReportComponentInstanceApplied: []*hooks.ComponentInstanceChange{{
+							Addr: mustAbsComponentInstance("component.self"),
+						}},
 					},
 				},
 			},

internal/stacks/stackruntime/internal/stackeval/component_instance.go

@@ -22,6 +22,7 @@ import (
 	"github.com/hashicorp/terraform/internal/providers"
 	"github.com/hashicorp/terraform/internal/stacks/stackaddrs"
 	"github.com/hashicorp/terraform/internal/stacks/stackplan"
+	"github.com/hashicorp/terraform/internal/stacks/stackruntime/hooks"
 	"github.com/hashicorp/terraform/internal/stacks/stackstate"
 	"github.com/hashicorp/terraform/internal/states"
 	"github.com/hashicorp/terraform/internal/terraform"
@@ -192,6 +193,7 @@ func (c *ComponentInstance) CheckModuleTreePlan(ctx context.Context) (*plans.Pla
 		ctx, c.tracingName()+" modules", &c.moduleTreePlan,
 		func(ctx context.Context) (*plans.Plan, tfdiags.Diagnostics) {
 			var diags tfdiags.Diagnostics
+			h := hooksFromContext(ctx)
 
 			if c.mode == plans.DestroyMode {
 
@@ -203,7 +205,13 @@ func (c *ComponentInstance) CheckModuleTreePlan(ctx context.Context) (*plans.Pla
 					// and never applied, or that it was previously destroyed
 					// via an earlier destroy operation.
 					//
-					// Return a dummy plan:
+					// Return a dummy plan and send dummy events:
+					hookSingle(ctx, h.PendingComponentInstancePlan, c.Addr())
+					seq, ctx := hookBegin(ctx, h.BeginComponentInstancePlan, h.ContextAttach, c.Addr())
+					hookMore(ctx, seq, h.ReportComponentInstancePlanned, &hooks.ComponentInstanceChange{
+						Addr: c.Addr(),
+					})
+					hookMore(ctx, seq, h.EndComponentInstancePlan, c.Addr())
 					return &plans.Plan{
 						UIMode:    plans.DestroyMode,
 						Complete:  true,
@@ -220,7 +228,6 @@ func (c *ComponentInstance) CheckModuleTreePlan(ctx context.Context) (*plans.Pla
 				// outputs from this component can read from the refresh result
 				// without causing a cycle.
 
-				h := hooksFromContext(ctx)
 				hookSingle(ctx, h.PendingComponentInstancePlan, c.Addr())
 				seq, planCtx := hookBegin(ctx, h.BeginComponentInstancePlan, h.ContextAttach, c.Addr())
 
@@ -336,7 +343,6 @@ func (c *ComponentInstance) CheckModuleTreePlan(ctx context.Context) (*plans.Pla
 				}
 			}
 
-			h := hooksFromContext(ctx)
 			hookSingle(ctx, h.PendingComponentInstancePlan, c.Addr())
 			seq, ctx := hookBegin(ctx, h.BeginComponentInstancePlan, h.ContextAttach, c.Addr())
 			plan, moreDiags := PlanComponentInstance(ctx, c.main, c.PlanPrevState(), opts, []terraform.Hook{
@@ -384,6 +390,15 @@ func (c *ComponentInstance) ApplyModuleTreePlan(ctx context.Context, plan *plans
 
 		// If we're destroying and there's nothing to destroy, then we can
 		// consider this a no-op.
+		// We still need to report through the hooks that this component instance has been handled.
+		h := hooksFromContext(ctx)
+		hookSingle(ctx, hooksFromContext(ctx).PendingComponentInstanceApply, c.Addr())
+		seq, ctx := hookBegin(ctx, h.BeginComponentInstanceApply, h.ContextAttach, c.Addr())
+		hookMore(ctx, seq, h.ReportComponentInstanceApplied, &hooks.ComponentInstanceChange{
+			Addr: c.Addr(),
+		})
+		hookMore(ctx, seq, h.EndComponentInstanceApply, c.Addr())
+
 		return &ComponentInstanceApplyResult{
 			FinalState:                      plan.PriorState, // after refresh
 			AffectedResourceInstanceObjects: resourceInstanceObjectsAffectedByStackPlan(stackPlan),