at least the linter will be happy

Author: mildwonkey

internal/command/arguments/state_show_test.go

@@ -17,14 +17,16 @@ func TestParseStateShow_valid(t *testing.T) {
 		"address only": {
 			[]string{"test_instance.foo"},
 			&StateShow{
-				Address: "test_instance.foo",
+				Address:  "test_instance.foo",
+				ViewType: ViewHuman,
 			},
 		},
 		"with state path": {
 			[]string{"-state=foobar.tfstate", "test_instance.foo"},
 			&StateShow{
 				StatePath: "foobar.tfstate",
 				Address:   "test_instance.foo",
+				ViewType:  ViewHuman,
 			},
 		},
 	}
@@ -50,7 +52,7 @@ func TestParseStateShow_invalid(t *testing.T) {
 	}{
 		"no arguments": {
 			nil,
-			&StateShow{},
+			&StateShow{ViewType: ViewHuman},
 			tfdiags.Diagnostics{
 				tfdiags.Sourceless(
 					tfdiags.Error,
@@ -62,7 +64,8 @@ func TestParseStateShow_invalid(t *testing.T) {
 		"too many arguments": {
 			[]string{"test_instance.foo", "test_instance.bar"},
 			&StateShow{
-				Address: "test_instance.foo",
+				Address:  "test_instance.foo",
+				ViewType: ViewHuman,
 			},
 			tfdiags.Diagnostics{
 				tfdiags.Sourceless(
@@ -74,7 +77,7 @@ func TestParseStateShow_invalid(t *testing.T) {
 		},
 		"unknown flag": {
 			[]string{"-boop"},
-			&StateShow{},
+			&StateShow{ViewType: ViewHuman},
 			tfdiags.Diagnostics{
 				tfdiags.Sourceless(
 					tfdiags.Error,

internal/command/state_show.go

@@ -131,14 +131,14 @@ func (c *StateShowCommand) Run(args []string) int {
 
 	state := stateMgr.State()
 	if state == nil {
-		diags = diags.Append(fmt.Errorf(errStateNotFound))
+		diags = diags.Append(errStateNotFound)
 		view.Diagnostics(diags)
 		return 1
 	}
 
 	is := state.ResourceInstance(addr)
 	if !is.HasCurrent() {
-		diags = diags.Append(fmt.Errorf(errNoInstanceFound))
+		diags = diags.Append(errNoInstanceFound)
 		view.Diagnostics(diags)
 		return 1
 	}

internal/command/views/show.go

@@ -191,6 +191,6 @@ func (v *ShowJSON) DisplayResourceInstanceState(rs *states.Resource, rAddr addrs
 		v.view.streams.Eprintf("JSON parse error: %s", err)
 		return 1
 	}
-	v.view.streams.Println(string(prettyJSON.Bytes()))
+	v.view.streams.Println(prettyJSON.String())
 	return 0
 }