add more test cases to ensure destroying is no issue

Author: DanielMSchmidt

internal/terraform/context_plan_actions_test.go

@@ -26,6 +26,7 @@ func TestContextPlan_actions(t *testing.T) {
 		module             map[string]string
 		buildState         func(*states.SyncState)
 		planActionResponse *providers.PlanActionResponse
+		planOpts           *PlanOpts
 
 		expectPlanActionCalled    bool
 		expectValidateDiagnostics func(m *configs.Config) tfdiags.Diagnostics
@@ -616,6 +617,63 @@ output "my_output2" {
 				return tfdiags.Diagnostics{tfdiags.Sourceless(tfdiags.Error, "Can not access actions", "Actions can not be accessed, they have no state and can only be referenced with a resources lifecycle action_trigger events list. Tried to access action.test_unlinked.my_action."), tfdiags.Sourceless(tfdiags.Error, "Can not access actions", "Actions can not be accessed, they have no state and can only be referenced with a resources lifecycle action_trigger events list. Tried to access action.test_unlinked.my_action.")}
 			},
 		},
+
+		"destroy run": {
+			module: map[string]string{
+				"main.tf": `
+terraform { experiments = [actions] }
+action "test_unlinked" "hello" {}
+resource "test_object" "a" {
+  lifecycle {
+    action_trigger {
+      events = [before_create, after_update]
+      actions = [action.test_unlinked.hello]
+    }
+  }
+}
+`,
+			},
+			expectPlanActionCalled: false,
+			planOpts:               SimplePlanOpts(plans.DestroyMode, InputValues{}),
+		},
+
+		// Since if we just destroy a node there is no reference to an action in config, we try
+		// to provoke an error by just removing a resource instance.
+		"destroying expanded node": {
+			module: map[string]string{
+				"main.tf": `
+terraform { experiments = [actions] }
+action "test_unlinked" "hello" {}
+resource "test_object" "a" {
+  count = 2
+  lifecycle {
+    action_trigger {
+      events = [before_create, after_update]
+      actions = [action.test_unlinked.hello]
+    }
+  }
+}
+`,
+			},
+			expectPlanActionCalled: false,
+
+			buildState: func(s *states.SyncState) {
+				s.SetResourceInstanceCurrent(mustResourceInstanceAddr("test_object.a[0]"), &states.ResourceInstanceObjectSrc{
+					AttrsJSON: []byte(`{}`),
+					Status:    states.ObjectReady,
+				}, mustProviderConfig(`provider["registry.terraform.io/hashicorp/test"]`))
+
+				s.SetResourceInstanceCurrent(mustResourceInstanceAddr("test_object.a[1]"), &states.ResourceInstanceObjectSrc{
+					AttrsJSON: []byte(`{}`),
+					Status:    states.ObjectReady,
+				}, mustProviderConfig(`provider["registry.terraform.io/hashicorp/test"]`))
+
+				s.SetResourceInstanceCurrent(mustResourceInstanceAddr("test_object.a[2]"), &states.ResourceInstanceObjectSrc{
+					AttrsJSON: []byte(`{}`),
+					Status:    states.ObjectReady,
+				}, mustProviderConfig(`provider["registry.terraform.io/hashicorp/test"]`))
+			},
+		},
 	} {
 		t.Run(name, func(t *testing.T) {
 			if tc.toBeImplemented {
@@ -683,7 +741,12 @@ output "my_output2" {
 				prevRunState = states.BuildState(tc.buildState)
 			}
 
-			_, diags = ctx.Plan(m, prevRunState, SimplePlanOpts(plans.NormalMode, InputValues{}))
+			opts := SimplePlanOpts(plans.NormalMode, InputValues{})
+			if tc.planOpts != nil {
+				opts = tc.planOpts
+			}
+
+			_, diags = ctx.Plan(m, prevRunState, opts)
 
 			if tc.expectPlanDiagnostics != nil {
 				tfdiags.AssertDiagnosticsMatch(t, diags, tc.expectPlanDiagnostics(m))