configs: Fix module loader nil pointer panic

In configurations which have already been initialized, updating the
source of a non-root module call to an invalid value could cause a nil
pointer panic. This commit fixes the bug and adds test coverage.

Author: alisdair

internal/configs/configload/loader_load.go

@@ -61,7 +61,7 @@ func (l *Loader) moduleWalkerLoad(req *configs.ModuleRequest) (*configs.Module,
 	var diags hcl.Diagnostics
 
 	// Check for inconsistencies between manifest and config
-	if req.SourceAddr.String() != record.SourceAddr {
+	if req.SourceAddr != nil && req.SourceAddr.String() != record.SourceAddr {
 		diags = append(diags, &hcl.Diagnostic{
 			Severity: hcl.DiagError,
 			Summary:  "Module source has changed",

internal/configs/configload/loader_snapshot_test.go

@@ -1,6 +1,7 @@
 package configload
 
 import (
+	"os"
 	"path/filepath"
 	"reflect"
 	"testing"
@@ -71,6 +72,31 @@ module "child_b" {
 
 }
 
+func TestLoadConfigWithSnapshot_invalidSource(t *testing.T) {
+	fixtureDir := filepath.Clean("testdata/already-installed-now-invalid")
+
+	old, _ := os.Getwd()
+	os.Chdir(fixtureDir)
+	defer os.Chdir(old)
+
+	loader, err := NewLoader(&Config{
+		ModulesDir: ".terraform/modules",
+	})
+	if err != nil {
+		t.Fatalf("unexpected error from NewLoader: %s", err)
+	}
+
+	_, _, diags := loader.LoadConfigWithSnapshot(".")
+	assertDiagnosticCount(t, diags, 2)
+	d := diags[0]
+	if got, want := d.Summary, "Variables not allowed"; got != want {
+		t.Errorf("Wrong diag summary\ngot:  %s\nwant: %s", got, want)
+	}
+	if got, want := d.Subject.Filename, "foo/main.tf"; got != want {
+		t.Errorf("Wrong diag filename\ngot:  %s\nwant: %s", got, want)
+	}
+}
+
 func TestSnapshotRoundtrip(t *testing.T) {
 	fixtureDir := filepath.Clean("testdata/already-installed")
 	loader, err := NewLoader(&Config{

internal/configs/configload/loader_test.go

@@ -14,7 +14,7 @@ func assertNoDiagnostics(t *testing.T, diags hcl.Diagnostics) bool {
 
 func assertDiagnosticCount(t *testing.T, diags hcl.Diagnostics, want int) bool {
 	t.Helper()
-	if len(diags) != 0 {
+	if len(diags) != want {
 		t.Errorf("wrong number of diagnostics %d; want %d", len(diags), want)
 		for _, diag := range diags {
 			t.Logf("- %s", diag)

internal/configs/configload/testdata/already-installed-now-invalid/.terraform/modules/modules.json

@@ -0,0 +1 @@
+{"Modules":[{"Key":"","Source":"","Dir":"."},{"Key":"foo","Source":"./foo","Dir":"foo"},{"Key":"foo.bar","Source":"./bar","Dir":"foo/bar"}]}

internal/configs/configload/testdata/already-installed-now-invalid/foo/bar/main.tf

@@ -0,0 +1,3 @@
+output "hello" {
+  value = "Hello from foo/bar"
+}

internal/configs/configload/testdata/already-installed-now-invalid/foo/main.tf

@@ -0,0 +1,3 @@
+module "bar" {
+  source = "${path.module}/bar"
+}

internal/configs/configload/testdata/already-installed-now-invalid/root.tf

@@ -0,0 +1,3 @@
+module "foo" {
+  source  = "./foo"
+}