check function descriptions directly

Now that we dynamically add scoped versions to the global functions we
can't check the static Descriptions list. This should be OK since the
function descriptions are taken directly from Descriptions list, and if
any other scoped functions were added in the future, they may not be
coming from the current global set of functions anyway.

Author: jbardin

internal/lang/funcs/descriptions.go

@@ -3,7 +3,9 @@
 
 package funcs
 
-import "github.com/zclconf/go-cty/cty/function"
+import (
+	"github.com/zclconf/go-cty/cty/function"
+)
 
 type descriptionEntry struct {
 	// Description is a description for the function.

internal/lang/functions.go

@@ -178,7 +178,8 @@ func (s *Scope) Functions() map[string]function.Function {
 		// namespaces that can serve as external extension points.
 		s.funcs = make(map[string]function.Function, len(coreFuncs)*2)
 		for name, fn := range coreFuncs {
-			s.funcs[name] = funcs.WithDescription(name, fn)
+			fn = funcs.WithDescription(name, fn)
+			s.funcs[name] = fn
 			s.funcs["core::"+name] = fn
 		}
 

internal/lang/functions_descriptions_test.go

@@ -5,28 +5,14 @@ package lang
 
 import (
 	"testing"
-
-	"github.com/hashicorp/terraform/internal/lang/funcs"
 )
 
 func TestFunctionDescriptions(t *testing.T) {
 	scope := &Scope{
 		ConsoleMode: true,
 	}
-	// This will implicitly test the parameter description count since
-	// WithNewDescriptions will panic if the number doesn't match.
-	allFunctions := scope.Functions()
-
-	// plantimestamp isn't available with ConsoleMode: true
-	expectedFunctionCount := len(funcs.DescriptionList) - 1
-
-	if len(allFunctions) != expectedFunctionCount {
-		t.Errorf("DescriptionList length expected: %d, got %d", len(allFunctions), expectedFunctionCount)
-	}
-
-	for name := range allFunctions {
-		_, ok := funcs.DescriptionList[name]
-		if !ok {
+	for name, fn := range scope.Functions() {
+		if fn.Description() == "" {
 			t.Errorf("missing DescriptionList entry for function %q", name)
 		}
 	}