command/format: Reduce extra whitespaces & new lines#21334
Conversation
|
Off topic, but since you are in there, what do you think about reducing the newlines between |
|
@mildwonkey Sure, are 2 lines ok, or would you go as far as 1 empty line? I'm slightly more inclined to keeping it at 2 as we use 1 line for separating resources and this is whole new section, so the separation should be a bit more prominent, IMO? |
|
Does this / could this also fix #14858, which has been open for 2 years (!!!) to remove a single extra newline after |
pselle
left a comment
There was a problem hiding this comment.
Read through this a few times, and looks good to me! Looks like prior comments are related to making an additional change, and this PR already does a couple extra hoops (although, do have at, if you want to do the 3=>2 change)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
The original goal was to reduce newlines between each output in
terraform show, as demonstrated in one of the tests cases, but I also found one extra trailing whitespace printing for untainted (most) resources.