Ensure for_each values wholly known for sets#22597
Merged
pselle merged 6 commits intohashicorp:masterfrom Sep 3, 2019
Merged
Conversation
hashibot
reviewed
Aug 28, 2019
pselle
changed the title
jbardin
approved these changes
Sep 3, 2019
Contributor
Author
|
@venky999 It'll be in the next release, and that will be 0.12.8. |
|
@pselle thank you |
4 tasks
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
appilon
added
sdkv1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of a set that has some unknown values during the course of a plan (such as a set referencing a variable in an expression), Terraform would panic as it would attempt to convert the unknown value to a string in the evaluation of
for_each. Instead, we should check for whollyknown state forfor_eachin the case of sets, so that we can carry on and the appropriate error will be displayed if a value is indeed unknown, or in the case of the bug, a variable will be evaluated and the plan/apply can continue.Fixes #22580, #22629