Show warnings even if no changes

[nyurik]

Fixes #22541

This change will print warnings, such as deprecations,
even if plan has no changes.

[apparentlymart]

Thanks for working on this @nyurik!

This does look like the right cause. Thanks for tracking that down! I left feedback inline about a slightly different approach to fixing it which I think will make this codepath easier to follow and maintain in future, while getting the same result.

[nyurik]

@apparentlymart thanks, I updated the PR. Is there anything else that needs to be done here, or any specific person to ping to review it? Thanks!

[apparentlymart]

Thanks for the updates, @nyurik! This looks good to me, and I'm going to merge it.

[nyurik]

@apparentlymart would it be possible to backport this to 0.11 branch? This way it will make migration 0.11 -> 0.12 much easier -- we would simply need to migrate to the latest of the 0.11 branch, and our terraforms will instantly start showing any kind of upgrade warnings - thus we will be able to fix them before actually trying to migrate to 0.12.

Update I created a #24169 that includes both the changelog and the actual patch

[nyurik]

Update -- seems that 0.11 had a different output code. I did make a backport for v0.12 #24169 - hopefully can be merged & published soon. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.