backend/remote: do not panic if PrepareConfig or Configure receive null#25135
Merged
mildwonkey merged 2 commits intomasterfrom Jun 5, 2020
Merged
backend/remote: do not panic if PrepareConfig or Configure receive null#25135mildwonkey merged 2 commits intomasterfrom
mildwonkey merged 2 commits intomasterfrom
Conversation
objects If a user cancels (ctrl-c) terraform init while it is requesting missing configuration options for the remote backend, the PrepareConfig and Configure functions would receive a null cty.Value which would result in panics. This PR adds a check for null objects to the two functions in question. Fixes #23992
Codecov Report
|
Contributor
Author
|
My understanding is that it is valid to exit early from PrepareConfig without an error message because that situation only occurs on cancelation, but I can easily add a diagnostic message to both of these if I am mistaken. |
alisdair
approved these changes
Jun 5, 2020
Contributor
alisdair
left a comment
alisdair
left a comment
There was a problem hiding this comment.
This looks good to me 👍
mildwonkey
added a commit
that referenced
this pull request
Jun 12, 2020
…ll (#25135) * backend/remote: do not panic if PrepareConfig or Configure receive null objects If a user cancels (ctrl-c) terraform init while it is requesting missing configuration options for the remote backend, the PrepareConfig and Configure functions would receive a null cty.Value which would result in panics. This PR adds a check for null objects to the two functions in question. Fixes #23992
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objects
If a user cancels (ctrl-c) terraform init while it is requesting missing
configuration options for the remote backend, the PrepareConfig and
Configure functions would receive a null cty.Value which would result in
panics. This PR adds a check for null objects to the two functions in
question.
Fixes #23992
I have no idea how to test this, so please enjoy a screenshot showing the fix: