Skip to content

Upgrade hcl and go-cty#25216

Merged
alisdair merged 2 commits intomasterfrom
alisdair/upgrade-deps
Jun 11, 2020
Merged

Upgrade hcl and go-cty#25216
alisdair merged 2 commits intomasterfrom
alisdair/upgrade-deps

Conversation

@alisdair alisdair requested a review from a team June 11, 2020 16:48
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2020

Codecov Report

Merging #25216 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
states/statefile/version4.go 58.16% <0.00%> (+0.28%) ⬆️
terraform/evaluate.go 53.60% <0.00%> (+0.45%) ⬆️
dag/marshal.go 53.40% <0.00%> (+1.13%) ⬆️

Copy link
Copy Markdown
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 I have a small list of issues that should also be closed with this PR, too! 🎉

@alisdair
Copy link
Copy Markdown
Contributor Author

@mildwonkey I tried to spelunk for all the related issues I could find, but I could have missed some! Feel free to add others to the PR description or otherwise link them.

@alisdair alisdair merged commit 9303b9f into master Jun 11, 2020
@alisdair alisdair deleted the alisdair/upgrade-deps branch June 11, 2020 17:41
@grobie
Copy link
Copy Markdown

grobie commented Jun 14, 2020

@alisdair @jbardin Thanks for this! Will this be part of the next Terraform version? I ran into a Terraform crash when using the hashicorp/terraform-provider-kubernetes-alpha provider, and it seems it's also the result of https://github.com/zclconf/go-cty/pull/55

panic: interface conversion: interface {} is *cty.unknownType, not bool

@alisdair
Copy link
Copy Markdown
Contributor Author

@grobie Yes, this dependency upgrade will be released in Terraform 0.13.0-beta2.

@grobie
Copy link
Copy Markdown

grobie commented Jul 1, 2020

@alisdair Thanks. It appears Terraform 0.13.0 is still not advised to be used in production and some time out. Any chance to release a new 0.12.x version with the fixes for these terraform panics? It's really hard to use the current kubernetes-alpha provider as Terraform always crashes when attempting to render a diff for a K8s deployment.

@alisdair
Copy link
Copy Markdown
Contributor Author

alisdair commented Jul 2, 2020

We do not currently have plans to release another 0.12.x version. All our efforts are on releasing 0.13.0, hopefully in just a few weeks time.

@ghost
Copy link
Copy Markdown

ghost commented Jul 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants