command/apply: Remove implicit init call#25233
Merged
Conversation
The positional argument passed to apply was once used to specify a source for a Terraform module to fetch and initialize (#337). This functionality was removed from the init command later (#15032) but not completely removed from apply. This code was non-functional but largely not harmful, except for a very specific case: when passing an absolute path to a plan file as the positional argument on Windows, the getter.Detect code would incorrectly interpret the path as a URL. This caused init to fail and the apply command would exit with code 1 but without diagnostics. This commit removes this codepath, which fixes this bug, and should otherwise have no effect on the supported behaviour of apply.
Codecov Report
|
jbardin
approved these changes
Jun 12, 2020
paddycarver
added a commit
to hashicorp/terraform-plugin-test
that referenced
this pull request
Jul 9, 2020
It turns out that hashicorp/terraform#25233 means that referring to configuration files by absolute paths means that this library doesn't work for Windows users using Terraform versions before 0.13.0-beta2. By forcing relative paths, we can sidestep this bug, and make this work across a wider range of Terraform versions on Windows.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The positional argument passed to apply was once used to specify a source for a Terraform module to fetch and initialize (#337). This functionality was removed from the
initcommand later (#15032) but not completely removed fromapply.This code was non-functional but largely not harmful, except for a very specific case (#25068): when passing an absolute path to a plan file as the positional argument on Windows, the
getter.Detectcode would incorrectly interpret the path as a URL. This caused init to fail and the apply command would exit with code 1 but without diagnostics.This commit removes this codepath, which fixes this bug, and should otherwise have no effect on the supported behaviour of apply.
Fixes #25068
Screenshots
Manual verification of the fix on Windows 10: