winrm connection timeout, perhaps

[mildwonkey]

2 commits here:

1. Upgraded github.com/masterzen/winrm and github.com/packer-community/winrmcp libraries to lates. These did not make a different to the issue I was troubleshooting, but it also did no harm so I thought it worth upgrading. No harm in rolling this commit back if there are any concerns.
2. Added the configured connection timeout to the winrm.Endpoint. This timeout is used in the underlying tcp connection: (winrm documentation)

This is not a solution to #22006 - I am still working on a reproduction that succeeds in one version of terraform and hangs in another - but I think this is a solid first step: actual timeout errors as opposed to hanging.

As a side note/additional information: The configured timeout (in both packer and terraform) is used in the winrm.NewClientWithParameters. Packer does not set the winrm.Endpoint timeout (defaults to 60s).

[codecov]

Codecov Report

Merging #25350 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
communicator/winrm/communicator.go	54.12% <100.00%> (+0.42%)	⬆️
terraform/node_resource_plan.go	93.44% <0.00%> (+1.63%)	⬆️

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.