command: Fix state mv for only resource in module#25523
Merged
Conversation
Codecov Report
|
mildwonkey
approved these changes
Jul 9, 2020
Contributor
mildwonkey
left a comment
mildwonkey
left a comment
There was a problem hiding this comment.
Excellent, and what an interesting subtle bug!
| // Update the address before adding it to the state. | ||
| rs.Addr = addrTo | ||
| stateTo.Module(addrTo.Module).Resources[addrTo.Resource.String()] = rs | ||
| stateTo.EnsureModule(addrTo.Module).Resources[addrTo.Resource.String()] = rs |
Contributor
There was a problem hiding this comment.
I like that this also clears up a bit of redundancy (more like unnecessary code) since EnsureModule is safe to run in place of Module (here, that is)!
When moving a resource block with multiple instances to a new address within the same module, we need to ensure that the target module is present as late as possible. Otherwise, deleting the resource from the original address triggers pruning, and the module is removed just before we try to add the resource to it, which causes a crash. Includes regression test which panics without this code change.
alisdair
force-pushed
the
alisdair/fix-state-mv-panic
branch
from
6c478b9 to
17e1c9d
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving a resource block with multiple instances to a new address within the same module, we need to ensure that the target module is present as late as possible. Otherwise, deleting the resource from the original address triggers pruning, and the module is removed just before we try to add the resource to it, which causes a crash.
Includes regression test which panics without this code change.
Fixes #25520