Fix error when multiple -no-color arguments are used

[zachwhaley]

Since -no-color is a global argument and not actually handled by terraform commands, it must be removed from the list of arguments sent to commands. However the current code assumes only a single -no-color argument is ever added. This can easily not be the case if someone has TF_CLI_ARGS set to include -no-color, e.g. in an automation system where color is not helpful, and a call to terraform also includes a -no-color argument.

This change removes all instances of -no-color from the argument list before sending it to the commands.

Fixes #25845

[hashicorp-cla]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #25847 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
command/meta.go	68.34% <100.00%> (+0.44%)	⬆️
terraform/node_resource_plan.go	91.80% <0.00%> (-1.64%)	⬇️

[alisdair]

This looks like a good fix to me, thank you! 👏

Are you able to sign the CLA?

[zachwhaley]

Are you able to sign the CLA?

I'm almost certain. Just getting advice from my company.

[zachwhaley]

BTW, still here and still working to get that CLA signed. Thanks for the patience 😊

[alisdair]

Thank you! 🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.