don't connect module closers to destroy nodes#26186
Conversation
One of the tenants of the graph transformations is that resource destroy nodes can only be ordered relative to other resources, and can't be referenced directly. This was broken by the module close node which naively connected to all module nodes, creating cycles in some cases when edges are reversed from CreateBeforeDestroy.
Codecov Report
|
mildwonkey
left a comment
mildwonkey
left a comment
There was a problem hiding this comment.
We'll have to do some digging, I think there are a number of issues open at this point that this can close!
| ModuleCall: modCall, | ||
| } | ||
| var v dag.Vertex = n | ||
| var expander dag.Vertex = n |
There was a problem hiding this comment.
I appreciate this clearer variable name!
|
@jbardin wrote:
I'm confused. Did you mean tenets? |
|
@Nuru, sorry, that was a typo. Thanks |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
3 participants
One of the tenets of the graph transformations is that resource destroy
nodes can only be ordered relative to other resources, and can't be
referenced directly. This was broken by the module close node which
naively connected to all nodes within the module, creating cycles in some
cases when edges are reversed from CreateBeforeDestroy.
Fixes #26166