Skip to content

AzureRM backend: correctly lookup environment from metadata host#26463

Merged
jbardin merged 1 commit intomasterfrom
kt/azurerm-secret-backend-fix
Oct 5, 2020
Merged

AzureRM backend: correctly lookup environment from metadata host#26463
jbardin merged 1 commit intomasterfrom
kt/azurerm-secret-backend-fix

Conversation

@katbyte
Copy link
Copy Markdown
Contributor

@katbyte katbyte commented Oct 1, 2020

This should fix an issue when using the metadata host to lookup the environments from.

@apparentlymart
Copy link
Copy Markdown
Contributor

Hi @katbyte! I just wanted to note that the Terraform Core team isn't really equipped to review changes to the Azure backend but that if someone else familiar with this code can work with you to review it then please feel free to merge it when you're ready and we'll plan to include it in the forthcoming Terraform 0.14.0. Thanks!

Copy link
Copy Markdown
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v0.14.0 milestone Oct 2, 2020
@jbardin jbardin merged commit 5e13d57 into master Oct 5, 2020
@tombuildsstuff tombuildsstuff deleted the kt/azurerm-secret-backend-fix branch October 6, 2020 06:26
jbardin added a commit that referenced this pull request Oct 19, 2020
Backport Azure Backend changes from #26463 to 0.13
@ghost
Copy link
Copy Markdown

ghost commented Nov 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants