jsonconfig: properly unwind and enumerate references#28884
Merged
mildwonkey merged 1 commit intomainfrom Jun 14, 2021
Merged
Conversation
The "references" included in the expression representation now properly unwrap for each traversal step, to match what was documented.
jbardin
approved these changes
Jun 7, 2021
alisdair
pushed a commit
that referenced
this pull request
Jun 18, 2021
The "references" included in the expression representation now properly unwrap for each traversal step, to match what was documented.
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "references" included in the expression representation now properly unwrap for each traversal step, to match what was documented.
This fixes #28860
[update: I made the version bump in a later PR] There isn't a format version specific to the configuration representation, and we're not changing the overall format of the plan representation, so I did not increase the plan's format version. I'm not confident about that, I will do so if anyone disagrees!