json-output: Omit unchanged resource_drift entries#28975
Merged
Conversation
Previously, if any resources were found to have drifted, the JSON plan output would include a drift entry for every resource in state. This commit aligns the JSON plan output with the CLI UI, and only includes those resources where the old value does not equal the new value---i.e. drift has been detected. Also fixes a bug where the "address" field was missing from the drift output, and adds some test coverage.
alisdair
added
the
1.0-backport
mildwonkey
approved these changes
Jun 18, 2021
Contributor
mildwonkey
left a comment
mildwonkey
left a comment
There was a problem hiding this comment.
👍 LGTM!
FWIW the whole json* package structure is a trap specially (and accidentally) designed to capture import cycles, sorry 🙃
ghost
mentioned this pull request
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if any resources were found to have drifted, the JSON plan output would include a drift entry for every resource in state. This commit aligns the JSON plan output with the CLI UI, and only includes those resources where the old value does not equal the new value—i.e. drift has been detected.
Also fixes a bug where the "address" field was missing from the drift output, and adds some test coverage.
(I attempted to refactor the code which determines which resources have drifted into a single location, but got stuck with import cycles. We make the decision about drift very late, after decoding the state values using the provider schema, which means that the implementation needs to refer to the
states,plans, andterraformpackages, while being called fromcommand/viewsandcommand/jsonplan.)