unmark object ID or Name for formatting

[jbardin]

It's possible that an "identifying" attribute could have marks. Make sure we don't return sensitive values as identifying attributes, and unmark the entire value when converting to a string.

Fixes #29374

[alisdair]

I'm not sure about this solution. Since the identifying attributes heuristic is out of the user's control, displaying a name/ID marked as sensitive seems dangerous to me.

What if instead of this, we check if the identifying attribute value is sensitive, and ignore it if so?

[jbardin]

The first check here is obj.HasMark(marks.Sensitive) to ignore the value, but I left the unmark call in order to remove any possible other marks in the future.

[alisdair]

Unless I'm misunderstanding, that will check if the containing object itself has the sensitive mark, but not the enclosed value (i.e. the name/ID string).

[jbardin]

Oh, you are correct! I had some refactoring I discarded and that check no longer makes sense. I'll drop sensitive values individually.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.