Empty nested attribute handling in diffs#29398
Merged
Conversation
Don't try to break down containers that are empty to render the diff, so we can avoid having to check for empty vs null in all cases.
jbardin
added
the
1.0-backport
alisdair
approved these changes
Aug 17, 2021
ghost
mentioned this pull request
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handling of null and empty containers when rendering a diff of nested attribute object types.
Empty containers can be rendered as single attributes to avoid the need to differentiate between empty and null in the element handling. Null containers were not handled at all, because the old block formatting would never nee null values.
Fixes #29382
Fixes #29385