Bug fix: Terraform workspace command returns zero exit code when given an invalid argument.#31318
Merged
jbardin merged 2 commits intohashicorp:mainfrom Dec 16, 2022
twittyc:twittyc/terraformWorkspaceInvalidArgsReturnsNon0
Merged
Bug fix: Terraform workspace command returns zero exit code when given an invalid argument.#31318jbardin merged 2 commits intohashicorp:mainfrom twittyc:twittyc/terraformWorkspaceInvalidArgsReturnsNon0
jbardin merged 2 commits intohashicorp:mainfrom
twittyc:twittyc/terraformWorkspaceInvalidArgsReturnsNon0
Conversation
Contributor
Author
|
This closes #31317 |
Contributor
|
Thanks for this submission! Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it! |
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Terraform workspace command will return a 0 return code even when invalid arguments are passed to the command.
For example,
terraform workspace seleectwill return a 0 (non-error) return code even though it's an invalid command. This PR updates the Run method to fall in line with other terraform commands and returns a proper non-zero return code when an invalid argument is passed toterraform workspace.This fix updates the return code to properly give an error
go testspass. Let me know if I need to do anything else or if you have any feedback :)