fix: don't reveal nested attributes with sensitive schema#32004
fix: don't reveal nested attributes with sensitive schema#32004
Conversation
6fd4a2f to
0fee440
Compare
Uk1288
left a comment
There was a problem hiding this comment.
🎉 good work! I was able to smoke test this with deep nested resources as well.
6b9ae24 to
35f2915
Compare
35f2915 to
f7198e2
Compare
|
@jbardin Hey, James, I revisited this change and fixed several inconsistencies with nested attributes, as well as standardized the I can't see what's going on with the vercel deployment, but there were some minor documentation changes to reflect the (sensitive value) output. |
Previously, there was mixed usage of "(sensitive)" and "(sensitive value)" and even though it was more common to see "(sensitive)", the thought is that it's a value we are hiding rather than describing something already shown.
d1a3ef3 to
bd744ad
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Description
Fixes several bugs in the plan diff rendering of nested attributes
I also added a lot more test coverage for single nested attribute mode and sensitive schema nested attributes
Sample Config
Before:
After:
Target Release
1.4.0, 1.3.5
Draft CHANGELOG entry
BUG FIXES
When rendering a diff of nested attributes, Terraform now hides the entire nested object if it is marked sensitive by the provider schema