Update HCL and go-cty to fix optional and default attributes #32178
Merged
liamcervante merged 4 commits intomainfrom Nov 10, 2022
Merged
Update HCL and go-cty to fix optional and default attributes #32178liamcervante merged 4 commits intomainfrom
liamcervante merged 4 commits intomainfrom
Conversation
alisdair
approved these changes
Nov 10, 2022
Contributor
alisdair
left a comment
There was a problem hiding this comment.
Great idea to add tests here as well as upstream, that really helps codify Terraform's expectations of the cty/hcl behaviour!
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
crw
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Add test cases to verify all the default and optional issues are fixed * actually commit all the tests * update go-cty * Update hcl
crw
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Add test cases to verify all the default and optional issues are fixed * actually commit all the tests * update go-cty * Update hcl
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target Release
1.3.5
Draft CHANGELOG entry
BUG FIXES