backend/oss: Ignore the getting oss endpoint error and using string concat instead; Improves the error message level#32295
Merged
alisdair merged 1 commit intohashicorp:mainfrom Dec 5, 2022
Conversation
Contributor
|
Thanks for this submission, I'll notify the core team. |
alisdair
suggested changes
Dec 2, 2022
Contributor
alisdair
left a comment
alisdair
left a comment
There was a problem hiding this comment.
Happy to merge this if you can fix the gofmt error! Please run gofmt on these files and push a new commit.
…oncat instead; Improves the error message level
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix getting oss endpoint error caused by network connection failed and other reasons. This error will break oss backend process. Considering all of oss endpoints have followed up pattern
oss-<RegionId>.aliyuncs.com, above error can be ignored.Fixes #
Target Release
1.4.x
Draft CHANGELOG entry
ENHANCEMENTS