Fixes overriding modules which have depends_on attribute set

[ekini]

Fixes #32795

Target Release

1.4.x

Draft CHANGELOG entry

BUG FIXES

• Enables overriding modules that have depends_on attribute set (although still doesn't allow to override depends_on , which is the intended behaviour)

[crw]

Thanks for this submission!

[liamcervante]

This fix looks good to me, before we merge could you extend one of the tests to cover using depends_on in this context?

There's some test data in testdata/valid-modules/override-module you can use. If you just add a depends on statement to the module in primary.tf: depends_on = ["example_resource.resource"] that will make the a test in module_merge_test.go fail. You can then make that test pass by updating the expected data in the test to include the the new depends_on data and means we'll capture this fix in any changes going forward.

Thanks!

[ekini]

Thank you for the feedback @liamcervante ! Added the test and it passes :)

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.