Prevent nil Colorize options when rendering state outputs#32840
Merged
Prevent nil Colorize options when rendering state outputs#32840
Conversation
jbardin
added
the
1.4-backport
jbardin
changed the title
apparentlymart
approved these changes
Mar 14, 2023
Contributor
apparentlymart
left a comment
apparentlymart
left a comment
There was a problem hiding this comment.
LGTM!
Agreed about switching this to use unexported fields and an explicit API for construction, modification, and usage, but also agreed that it should be a separate change.
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
ghost
mentioned this pull request
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering nested
niloutput values from state, the Colorize options could be set tonil. Ensure theRenderHumanOptsare always instantiated via their constructor. If a constructor is required, it would probably be safer to have no exported fields for the type, but that level of refactoring will have to be review separately.Fixes #32833
Target Release
v1.4.1