Improve environment variable support for the pg backend#33045
Improve environment variable support for the pg backend#33045liamcervante merged 2 commits intohashicorp:mainfrom
Conversation
This patch does two things:
- it adds environment variable support to the parameters that did
not have it (and uses `PG_CONN_STR` instead of `PGDATABASE` which is
actually more appropriate to match the behavior of other PostgreSQL
utilities)
- better documents how to give the connection parameters as environment
variables for the ones that were already supported based on the
recommendation of @bsouth00
I will prepare a backport of the documentation part of this once it is
merged.
Closes hashicorp#33024
|
Thanks @remilapeyre, I'll send this through traige. |
liamcervante
left a comment
There was a problem hiding this comment.
Hi @remilapeyre, this mostly looks fine to me. Just a single comment on the databaseName variable. I'm happy to merge once that's resolved!
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
Thanks @remilapeyre! This is all ready to go as part of v1.5! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This patch does two things:
PG_CONN_STRinstead ofPGDATABASEwhich is actually more appropriate to match the behavior of other PostgreSQL utilities)I will prepare a backport of the documentation part of this once it is merged.
Closes #33024
Target Release
1.5.0
Draft CHANGELOG entry
The
pgbackend now supports thePG_CONN_STR,PG_SCHEMA_NAME,PG_SKIP_SCHEMA_CREATION,PG_SKIP_TABLE_CREATIONandPG_SKIP_INDEX_CREATIONenvironment variables.Documentation page