Skip to content

backend/cos: Support endpoint#33656

Merged
kmoe merged 4 commits intohashicorp:mainfrom
lyu571:main
Aug 30, 2023
Merged

backend/cos: Support endpoint#33656
kmoe merged 4 commits intohashicorp:mainfrom
lyu571:main

Conversation

@lyu571
Copy link
Copy Markdown
Contributor

@lyu571 lyu571 commented Aug 10, 2023

Support endpoint for the COS backend

Target Release

1.5.x

Draft CHANGELOG entry

ENHANCEMENTS

  • Provide an endpoint way to access backend of Tencentcloud COS. This method can provide support for internal network URLs for customers.

@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Aug 10, 2023

Hi @crw @likexian plz help to review my PR.

@likexian
Copy link
Copy Markdown
Contributor

LGTM

@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Aug 11, 2023

HI @crw plz help to review my PR. :)

@lyu571 lyu571 changed the title Support endpoint for the COS backend backend/cos: support endpoint Aug 17, 2023
@lyu571 lyu571 changed the title backend/cos: support endpoint backend/cos: Support endpoint Aug 17, 2023
Copy link
Copy Markdown
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs comments

@crw
Copy link
Copy Markdown
Contributor

crw commented Aug 25, 2023

Hi @lyu571, as long as you are OK accepting this docs changes, we can merge this PR. Thanks!

Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>
@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Aug 29, 2023

Hi @lyu571, as long as you are OK accepting this docs changes, we can merge this PR. Thanks!

Hi @crw I've accepted all docs comments. Plz continues the processing. Thank you.

@kmoe kmoe added this to the v1.6.0 milestone Aug 29, 2023
@kmoe kmoe merged commit d3f4f37 into hashicorp:main Aug 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Sep 13, 2023

Hi @kmoe and @crw, the feature endpoint was required by our customer who already waited a while. Seems the latest(1.5.7) Terraform release doesn't include this PR. Could you put the release plan for this PR with high priority?

Maybe change the milestone from 1.6.0 to 1.5.x?

@crw
Copy link
Copy Markdown
Contributor

crw commented Sep 13, 2023

Hi @lyu571, the first version of the product with this feature will be 1.6.0. You should be able to see it in 1.6.0-beta1. Thanks!

@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Sep 14, 2023

Hi @lyu571, the first version of the product with this feature will be 1.6.0. You should be able to see it in 1.6.0-beta1. Thanks!

Oh, I see.
Looks like this version is a pre-release version that our customer cannot use in an official way.
May I ask what time the official 1.6.0 be released/available?

@crw
Copy link
Copy Markdown
Contributor

crw commented Sep 14, 2023

Early October. 1.6.0-beta2 was released today, then there will be two release candidate releases.

@lyu571
Copy link
Copy Markdown
Contributor Author

lyu571 commented Sep 15, 2023

Early October. 1.6.0-beta2 was released today, then there will be two release candidate releases.

ok. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants