test: allow using global variables in suite-level variable definitions#34699
test: allow using global variables in suite-level variable definitions#34699DanielMSchmidt merged 14 commits intomainfrom
Conversation
b76481b to
ae5f847
Compare
ae5f847 to
ef36fc0
Compare
ef36fc0 to
383d010
Compare
383d010 to
7ae7a20
Compare
9896221 to
42c478c
Compare
61f5aa0 to
df3ee21
Compare
17d9205 to
e573680
Compare
ed2a331 to
ea0856b
Compare
liamcervante
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of small things around naming and tidying up.
Generally a "TestSuite" refers to all the test files currently being executed not just the current test file, so there's a couple of places where I think we should change names and comments to reflect that.
Thanks!
Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
|
Just a note on the changelog entry. I usually start with the full command, so something like:
Or something like that. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This allows practitioners to define variables in
.tfvarfiles, environment variables, CLI flags and use them in the definition of suit-level variables in the top-level variables block.Fixes #34534
Fixes #34538
Target Release
1.8.x
Draft CHANGELOG entry
ENHANCEMENTS