Add support for partial addresses and targets that start with 'resource.'#35333
Merged
liamcervante merged 3 commits intomainfrom Jun 14, 2024
Merged
Add support for partial addresses and targets that start with 'resource.'#35333liamcervante merged 3 commits intomainfrom
liamcervante merged 3 commits intomainfrom
Conversation
liamcervante
added
the
1.9-backport
added 2 commits
June 12, 2024 14:18
…te/include-resource-prefix
DanielMSchmidt
approved these changes
Jun 12, 2024
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential bug where resource addresses that start with
resource.could not be parsed as partial addresses or targets. This is unlikely to ever be encountered because theresource.prefix is entirely optional, but still valid so we should support it.Target Release
1.9.0
Draft CHANGELOG entry
BUG FIXES
resource.could not be parsed as targets.