plan renderer: render unknown nested blocks properly#35644
Merged
liamcervante merged 1 commit intomainfrom Sep 11, 2024
Merged
Conversation
liamcervante
commented
Aug 27, 2024
9ad6770 to
a265b66
Compare
Contributor
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the rendering logic so that it properly renders the contents of a nested block that is becoming unknown. Previously, we'd only render a single item for the whole nested block. Now we should a single item being created that is unknown, and all existing entries being marked as deleted.
In addition, this change fixes a crash that would occur when nested blocks were becoming unknown and contained attributes that were forcing the resource to be replaced. We weren't properly accounting for the nested indices within the replacement list, and now since we are properly computing the diffs we are.
Fixes #35556
Target Release
v1.9.7
CHANGELOG entry
BUG FIXES