backends: Fix crash when interrupting during interactive prompt for values'#36448
Merged
backends: Fix crash when interrupting during interactive prompt for values'#36448
Conversation
dbanck
added
the
1.11-backport
SarahFrench
approved these changes
Feb 6, 2025
Member
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
This solves the panic that affects the gcs backend in the linked issue, and I believe testing at the level in this PR is appropriate 
2 tasks
fredouric
pushed a commit
to fredouric/terraform
that referenced
this pull request
Feb 11, 2025
…alues' (hashicorp#36448) * backends: Convert null values to empty objects before coercion * backends: add test case for interrupt crash * Add changelog
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that affects all remote state backends that implement the
backendbase.Base. When interrupting (Ctrl+c) during Terraform's interactive value prompt, we convert the resulting unknown value to a null value.Our generic
PrepareConfigwasn't prepared to handle nulls and crashed when applying the sdk-like defaults.Fixes #36420
Target Release
1.11.x
CHANGELOG entry