Conversation
liamcervante
reviewed
Feb 7, 2025
Contributor
liamcervante
left a comment
liamcervante
left a comment
There was a problem hiding this comment.
If you want to release this in v1.11, you need to add the relevant backport label and move the changelog description into .changes/backported.
Maed223
added
the
1.11-backport
brandonc
reviewed
Feb 7, 2025
brandonc
approved these changes
Feb 7, 2025
liamcervante
approved these changes
Feb 10, 2025
Maed223
deleted the
IPL-7602/saved-plan-apply-hangs-with-auto-approve-flag
branch
dbanck
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ngs-with-auto-approve-flag Fix: Saved plan apply hangs with `-auto-approve` flag using cloud backend
2 tasks
dbanck
added a commit
that referenced
this pull request
Feb 19, 2025
…ngs-with-auto-approve-flag (#36532) Fix: Saved plan apply hangs with `-auto-approve` flag using cloud backend Co-authored-by: Mark DeCrane <mark.decrane@hashicorp.com>
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When applying a saved plan with the
-auto-approveflag using the cloud backend, we would see the apply hang in the console. The only way to proceed was to confirm the run using the UI. Without the flag, the apply runs without any user confirmation as is the intended behavior. This bug fix avoids this hanging behavior by kicking off the apply regardless of whether automatic approval is given if a saved plan is being used– as is the behavior locally.Target Release
1.11.x
CHANGELOG entry