Skip to content

fix: bump aws-sdk-go-base/v2 from v2.0.0-beta.58 to v2.0.0-beta.62#36625

Merged
jar-b merged 1 commit intohashicorp:mainfrom
sebastianmarines:update-aws-sdk-go-base
Mar 6, 2025
Merged

fix: bump aws-sdk-go-base/v2 from v2.0.0-beta.58 to v2.0.0-beta.62#36625
jar-b merged 1 commit intohashicorp:mainfrom
sebastianmarines:update-aws-sdk-go-base

Conversation

@sebastianmarines
Copy link
Copy Markdown
Contributor

@sebastianmarines sebastianmarines commented Mar 4, 2025

Bump aws-sdk-go-base/v2 version

Fixes #36624

Target Release

1.11.x

CHANGELOG entry

bump aws-sdk-go-base/v2 from v2.0.0-beta.58 to v2.0.0-beta.62

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@sebastianmarines sebastianmarines requested a review from a team as a code owner March 4, 2025 07:14
@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app bot commented Mar 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Copy Markdown
Contributor

crw commented Mar 4, 2025

Thanks for this submission, this will need to be reviewed by the HashiCorp AWS provider team and it is in their queue. Thanks again!

bschaatsbergen
bschaatsbergen suggested changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bschaatsbergen bschaatsbergen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebastianmarines,

Thank you for taking a look at this, that's great. As #36624 (comment) states, it looks like hashicorp/aws-sdk-go-base#1248 added support for mx-central-1 which was released under v2.0.0-beta.61 (2025-01-15).

Thank you for bumping it to the latest beta release, which includes another region as well. Instead of updating the indirect dependency in the root go.mod, could you update the go.mod I tagged in the review comment?

@sebastianmarines sebastianmarines requested a review from a team as a code owner March 4, 2025 22:55
@jar-b jar-b requested review from a team as code owners March 5, 2025 15:21
@jar-b jar-b added the 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 5, 2025
jar-b
jar-b previously approved these changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 207.393s

@jar-b jar-b requested a review from bschaatsbergen March 5, 2025 15:40
bschaatsbergen
bschaatsbergen previously approved these changes Mar 5, 2025
View reviewed changes
jbardin
jbardin reviewed Mar 6, 2025
View reviewed changes
@sebastianmarines @jar-b
backend/s3: update hashicorp/aws-sdk-go-base/v2 to v2.0.0-beta62
9237b11 
This upgrade will add support for S3 backends in several new regions,
including `mx-central-1`.
@jar-b jar-b dismissed stale reviews from bschaatsbergen and themself via 9237b11 March 6, 2025 16:10
@jar-b jar-b force-pushed the update-aws-sdk-go-base branch from a17b794 to 9237b11 Compare March 6, 2025 16:10
@jar-b
Copy link
Copy Markdown
Member

jar-b commented Mar 6, 2025

Thanks for your contribution, @sebastianmarines!

@jar-b jar-b merged commit 9ac4b3a into hashicorp:main Mar 6, 2025
7 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Mar 6, 2025
Merged
2 tasks
@crw crw mentioned this pull request Mar 17, 2025
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jbardin jbardin jbardin approved these changes

@jar-b jar-b jar-b approved these changes

+1 more reviewer

@bschaatsbergen bschaatsbergen bschaatsbergen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 upstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid AWS Region when creating S3 backend in mx-central-1 region

5 participants

@sebastianmarines @crw @jar-b @jbardin @bschaatsbergen