ensure outputs carry sensitive marks forward#37212
Merged
Conversation
Sensitive marks were lost from module outputs during the namedvals rewrite. Ensure output are evaluated with sensitive in accordance with their configuration.
mildwonkey
approved these changes
Jun 4, 2025
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sensitive marks were lost from module outputs during the namedvals rewrite. Ensure output are evaluated with sensitive marks in accordance with their configuration.
Interestingly I found that the old access point of
lang.Data.GetOutputwas not removed long ago when we fixed module evaluation overall to always access the module objects. This method however was recently re-captured by the moduletest package. That code can probably be refactored to useGetModuleand we can remove theGetOutputcall to ensure uniformity of evaluation.