evaluate: return diagnostics instead of unknown for uninitialised locals and resources

[liamcervante]

…

This PR updates the behaviour for resources and locals, so that when referenced out of order they return explicit diagnostics stating this instead of simple unknown values.

Fixes #

Target Release

1.14.x

Rollback Plan

• If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

• This change is user-facing and I added a changelog entry.
• This change is not user-facing.

[jbardin]

Oh, I thought I has another PR to review too. What's here looks good, but did we want to also include GetResource? https://github.com/hashicorp/terraform/blob/main/internal/terraform/evaluate.go#L547

[liamcervante]

@jbardin, I think the resource should already be covered here: https://github.com/hashicorp/terraform/pull/37663/files#diff-287bfcd0fb97d5fe87495954e5e31240544a80b318e8a6aa1ed5da650eaf320aR576-R581?

[jbardin]

sorry, the GH diff was rendering differently than I was used to, and I didn't see that as under GetResource. LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.